[BEAM-7728] [SQL] Support ParquetTable #9054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wa! So nice! Will take a look! |
amaliujia
reviewed
Jul 13, 2019
| public class GenericRecordToRowTest implements Serializable { | ||
| @Rule public transient TestPipeline pipeline = TestPipeline.create(); | ||
|
|
||
| org.apache.beam.sdk.schemas.Schema payloadSchema = |
There was a problem hiding this comment.
mark as static and final?
amaliujia
reviewed
Jul 13, 2019
|
|
||
| @Override | ||
| public PDone buildIOWriter(PCollection<Row> input) { | ||
| throw new UnsupportedOperationException("Writing to a Parquet file is not supported"); |
There was a problem hiding this comment.
Will it be relatively easy to implement write by
?
There was a problem hiding this comment.
okay, let me try this.
|
@vectorijk if you don't mind, I can first merge your this PR and leave |
|
@amaliujia sgtm. I can implement ParquetWriter in another PR. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.