Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-7662] Create Python Combine load test job on Flink #9115

Merged
merged 1 commit into from
Jul 29, 2019
Merged

[BEAM-7662] Create Python Combine load test job on Flink #9115

merged 1 commit into from
Jul 29, 2019

Conversation

kamilwu
Copy link
Contributor

@kamilwu kamilwu commented Jul 22, 2019 •
edited
Loading

Based on the following proposal: https://s.apache.org/load-test-basic-operations

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status		 Build Status Build Status Build Status
Build Status
Python [Build Status] (https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)
[Build Status] (https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)
[Build Status] (https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)
[Build Status] (https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)		 --- Build Status
Build Status		 Build Status --- --- Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@kamilwu
Copy link
Contributor Author

kamilwu commented Jul 22, 2019

Run Seed Job

@kamilwu
Copy link
Contributor Author

kamilwu commented Jul 22, 2019

Run Load Tests Python Combine Flink Batch

@kamilwu
Copy link
Contributor Author

kamilwu commented Jul 22, 2019

Run Seed Job

@kamilwu
Copy link
Contributor Author

kamilwu commented Jul 22, 2019

Run Seed Job

@kamilwu
Copy link
Contributor Author

kamilwu commented Jul 22, 2019

Run Load Tests Python Combine Flink Batch

@kamilwu
Copy link
Contributor Author

kamilwu commented Jul 23, 2019

Run Seed Job

@kamilwu
Copy link
Contributor Author

kamilwu commented Jul 23, 2019

Run Seed Job

@kamilwu
Copy link
Contributor Author

kamilwu commented Jul 23, 2019

Run Load Tests Python Combine Flink Batch

@kamilwu
Copy link
Contributor Author

kamilwu commented Jul 23, 2019

Run Seed Job

@kamilwu
Copy link
Contributor Author

kamilwu commented Jul 23, 2019

Run Load Tests Python Combine Flink Batch

@kamilwu
Copy link
Contributor Author

kamilwu commented Jul 23, 2019

Run Seed Job

@kamilwu
Copy link
Contributor Author

kamilwu commented Jul 23, 2019

Run Load Tests Python Combine Flink Batch

@kamilwu
Copy link
Contributor Author

kamilwu commented Jul 24, 2019

Run Seed Job

@kamilwu
Copy link
Contributor Author

kamilwu commented Jul 24, 2019

Run Load Tests Python Combine Flink Batch

@kamilwu kamilwu marked this pull request as ready for review July 24, 2019 08:43
@kamilwu
Copy link
Contributor Author

kamilwu commented Jul 24, 2019

R: @iemejia Could you take a look?

iemejia
iemejia approved these changes Jul 26, 2019
View reviewed changes
Copy link
Member

@iemejia iemejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Before merging just have a pretty minor question on the weird spaces red character.

.test-infra/jenkins/job_LoadTests_Combine_Flink_Python.groovy
* limitations under the License.
*/

import CommonJobProperties as commonJobProperties
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this caracters look weird? aren't normal spaces?

@iemejia iemejia merged commit bf19854 into apache:master Jul 29, 2019
@iemejia
Copy link
Member

iemejia commented Jul 29, 2019

It seems the red spaces are some issue of github while parsing groovy files. Locally it looks ok, no weird characters.
Thanks @kamilwu !

@kamilwu
Copy link
Contributor Author

kamilwu commented Jul 29, 2019

I reached the same conclusion. No idea why Github complains about those spaces since import ... as is a documented Groovy feature: http://groovy-lang.org/structure.html#_import_aliasing
Thanks @iemejia !

@kamilwu kamilwu deleted the combine-flink branch July 29, 2019 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iemejia iemejia iemejia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kamilwu @iemejia