[BEAM-7829] Add schema names when converting with AvroUtils.toAvroSchema #9247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please hold off on reviewing -- taking a look at the Spark strategy for naming schemas, I think this implementation introduces a bug. I'm creating a unit test to check and will push a fix. |
RyanSkraba
force-pushed
the
BEAM-7829-name-all-records
branch
from
79c9150
to
5b3c038
Compare
|
Run Java PreCommit |
RyanSkraba
force-pushed
the
BEAM-7829-name-all-records
branch
3 times, most recently
from
e7ddf44
to
7f57470
Compare
kanterov
reviewed
Aug 28, 2019
sdks/java/core/src/test/java/org/apache/beam/sdk/schemas/utils/AvroUtilsTest.java
Outdated
Show resolved
Hide resolved
|
I will wait for master build becoming green, and then we can merge it. |
RyanSkraba
force-pushed
the
BEAM-7829-name-all-records
branch
from
7f57470
to
2620da8
Compare
RyanSkraba
force-pushed
the
BEAM-7829-name-all-records
branch
from
2620da8
to
0871831
Compare
|
Run Java PreCommit |
1 similar comment
|
Run Java PreCommit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a subtle problem with unnamed records in Avro and Java -- they can be used to correctly serialize/deserialize binary data as long as nobody counts on serializing/deserializing the actual Avro schema as a JSON string.
This can work if both reader and writer can infer the schema from another source (like the Beam Schema), but is certain to break when passing the schema or record to a transform that expects the schema to meet the Avro specification.
More discussion at: https://issues.apache.org/jira/browse/AVRO-2492
This change ensures that no anonymous Avro records will be created as part of translating a Beam schema.
N.B. Credit goes to @iemejia for this implementation, I just cleaned up the tests.
N.B.2 I get some minor credit :D There were some bugs with potential namespace collisions. The internal implementation here should be very close to what Spark does with auto-generated Avro schemas.
R: @reuvenlax @kanterov
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.