BIGTOP-3650: Improve Hive's Debian packaging #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raised compat to '12' and followed some suggestions from Lintian.
iwasakims
approved these changes
Mar 7, 2022
There was a problem hiding this comment.
LGTM.
While v11 is recommended in manpage of debhelper on Ubuntu 18.04, I got no issue for running ./gradlew hive-pkg and lintian with the patch applied.
$ man debhelper
v11 This is the recommended mode of operation.
...
v12 This compatibility level is still open for development; use with caution.
|
thanks @iwasakims! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raised compat to '12' and followed some suggestions from Lintian.