Skip to content

Commit

Permalink
y
Browse files Browse the repository at this point in the history
Descriptions of the changes in this PR:
Handle handle non-ascii chars in username in merge script.

---
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

- [X] Make sure the PR title is formatted like:
    `<Issue # or BOOKKEEPER-#>: Description of pull request`
    `e.g. Issue 123: Description ...`
    `e.g. BOOKKEEPER-1234: Description ...`
- [X] Make sure tests pass via `mvn clean apache-rat:check install findbugs:check`.
- [X] Replace `<Issue # or BOOKKEEPER-#>` in the title with the actual Issue/JIRA number.

---

Author: jiazhai <zhaijia@live.com>

Reviewers: Enrico Olivelli <eolivelli@apache.org>

This closes #242 from jiazhai/issue_241
  • Loading branch information
jiazhai authored and eolivelli committed Jul 14, 2017
1 parent 8aac2ca commit 8bb699e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion dev/bk-merge-pr.py
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,7 @@ def get_reviewers(pr_num):
username = user['name'].strip()
if username is None:
continue
reviewers_emails.append('{0} <{1}>'.format(username, useremail))
reviewers_emails.append('{0} <{1}>'.format(username.encode('utf8'), useremail))
return ', '.join(reviewers_emails)

def main():
Expand Down

0 comments on commit 8bb699e

Please sign in to comment.