Skip to content

Commit

Permalink
Make build pass on JDK11, fix javadoc configuration
Browse files Browse the repository at this point in the history
Descriptions of the changes in this PR:

### Motivation

Build fails on recent JDK11 versions and on JDK11, see #2133, this is because javadoc has problems with references to core Java API when source version is set to 8.

### Changes
Upgrade Java doc plugin to latest 3.1.1 and disable auto linking to core Java classes with
`<detectJavaApiLink>false</detectJavaApiLink>
`
Closes #2133




Reviewers: Sijie Guo <None>

This closes #2134 from eolivelli/fix/javadoc-jdk11

(cherry picked from commit 5311e00)
Signed-off-by: eolivelli <eolivelli@apache.org>
  • Loading branch information
eolivelli committed Jul 27, 2019
1 parent a35e6c1 commit d2cd48a
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion pom.xml
Expand Up @@ -188,7 +188,7 @@
<maven-deploy-plugin.version>2.7</maven-deploy-plugin.version>
<maven-install-plugin.version>2.5.1</maven-install-plugin.version>
<maven-jar-plugin.version>2.4</maven-jar-plugin.version>
<maven-javadoc-plugin.version>3.0.0</maven-javadoc-plugin.version>
<maven-javadoc-plugin.version>3.1.1</maven-javadoc-plugin.version>
<maven-shade-plugin.version>3.1.0</maven-shade-plugin.version>
<maven-source-plugin.version>2.2.1</maven-source-plugin.version>
<maven-surefire-plugin.version>2.21.0</maven-surefire-plugin.version>
Expand Down Expand Up @@ -904,6 +904,7 @@
<doctitle>BookKeeper Java API (version ${project.version})</doctitle>
<overview>site/_site/overview/index.html</overview>
<show>package</show>
<detectJavaApiLink>false</detectJavaApiLink>
</configuration>
<executions>
<execution>
Expand Down

0 comments on commit d2cd48a

Please sign in to comment.