Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build fails on recent JDK11 versions #2133

Closed
eolivelli opened this issue Jul 26, 2019 · 0 comments · Fixed by #2134
Closed

Build fails on recent JDK11 versions #2133

eolivelli opened this issue Jul 26, 2019 · 0 comments · Fixed by #2134
Labels
type/bug

Comments

@eolivelli
Copy link
Contributor

CI started reporting errors about javadocs.
I can reproduce the same error on JDK11 and JDK22.
Even upgrading the javadoc plugin does not help.
I will try to send a fix soon

[INFO] Total time:  01:43 min
[INFO] Finished at: 2019-07-25T21:41:14Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:3.0.0:jar (attach-javadocs) on project bookkeeper-stats-api: MavenReportException: Error while generating Javadoc: 
[ERROR] Exit code: 1 - javadoc: error - The code being documented uses modules but the packages defined in https://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] 
[ERROR] Command line was: /usr/local/lib/jvm/openjdk11/bin/javadoc @options
[ERROR] 
[ERROR] Refer to the generated Javadoc files in '/home/travis/build/apache/bookkeeper/bookkeeper-stats/target/apidocs' dir.
[ERROR] -> [Help 1]
[ERROR]
@eolivelli eolivelli mentioned this issue Jul 26, 2019
Merged
eolivelli added a commit to eolivelli/bookkeeper that referenced this issue Jul 26, 2019
@eolivelli
Make build pass on JDK11, fix javadoc configuration
28b0d5d 
closes apache#2133
@eolivelli eolivelli mentioned this issue Jul 26, 2019
Merged
@29x10 29x10 mentioned this issue Jul 27, 2019
Merged
eolivelli added a commit that referenced this issue Jul 27, 2019
@eolivelli
Make build pass on JDK11, fix javadoc configuration
5311e00 
Descriptions of the changes in this PR:

### Motivation

Build fails on recent JDK11 versions and on JDK11, see #2133, this is because javadoc has problems with references to core Java API when source version is set to 8.

### Changes
Upgrade Java doc plugin to latest 3.1.1 and disable auto linking to core Java classes with
`<detectJavaApiLink>false</detectJavaApiLink>
`
Closes #2133




Reviewers: Sijie Guo <None>

This closes #2134 from eolivelli/fix/javadoc-jdk11
eolivelli added a commit that referenced this issue Jul 27, 2019
@eolivelli
Make build pass on JDK11, fix javadoc configuration
d2cd48a 
Descriptions of the changes in this PR:

### Motivation

Build fails on recent JDK11 versions and on JDK11, see #2133, this is because javadoc has problems with references to core Java API when source version is set to 8.

### Changes
Upgrade Java doc plugin to latest 3.1.1 and disable auto linking to core Java classes with
`<detectJavaApiLink>false</detectJavaApiLink>
`
Closes #2133




Reviewers: Sijie Guo <None>

This closes #2134 from eolivelli/fix/javadoc-jdk11

(cherry picked from commit 5311e00)
Signed-off-by: eolivelli <eolivelli@apache.org>
eolivelli added a commit that referenced this issue Jul 27, 2019
@eolivelli
Make build pass on JDK11, fix javadoc configuration
5e5d7a3 
Descriptions of the changes in this PR:

### Motivation

Build fails on recent JDK11 versions and on JDK11, see #2133, this is because javadoc has problems with references to core Java API when source version is set to 8.

### Changes
Upgrade Java doc plugin to latest 3.1.1 and disable auto linking to core Java classes with
`<detectJavaApiLink>false</detectJavaApiLink>
`
Closes #2133




Reviewers: Sijie Guo <None>

This closes #2134 from eolivelli/fix/javadoc-jdk11

(cherry picked from commit 5311e00)
Signed-off-by: eolivelli <eolivelli@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make build pass on JDK11, fix javadoc configuration eolivelli/bookkeeper
1 participant
@eolivelli