-
Notifications
You must be signed in to change notification settings - Fork 897
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Avoid usage of RocksDB deleteRange() in DbLedgerStorage
### Motivation There are few issues that are reconducible to a performance degradation in RocksDB when using deleteRange() feature (eg: apache/pulsar#1737 and others). There is some discussion going on RocksDB to address this issue: facebook/rocksdb#3959 In the meantime, we should rollback the change and don't use deleteRange until these issues are resolved. ### Changes This PR is essentially reverting back the commit YahooArchive@4b84990 from Yahoo branch (which was squashed when merging back to apache). The only addition here is to use `DELETE_ENTRIES_BATCH_SIZE` to amortize the cost of `batch.flush()` when there are many ledgers with few entries. Author: Matteo Merli <mmerli@apache.org> Reviewers: Ivan Kelly <ivank@apache.org>, Enrico Olivelli <eolivelli@gmail.com>, Sijie Guo <sijie@apache.org> This closes #1620 from merlimat/rollback-delete-range
- Loading branch information
Showing
1 changed file
with
55 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters