Journal scan should throw IOException when it reads negative length #2176
Labels
Comments
|
can you add version and stacktrace please? maybe FS type In my opinion the fix is simple |
reddycharan
pushed a commit
that referenced
this issue
Oct 24, 2019
Descriptions of the changes in this PR: ### Motivation During journal replay, we can encounter negative length value if there is journal corruption. Currently, due to this bug, we pass negative length to limit a buffer, which throws IllegalArgumentException. ### Changes Updated the Journal class to throw `IOException` with a clear message, instead of unclear `IllegalArgumentException`. Master Issue: #2176 Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Charan Reddy Guttapalem <reddycharan18@gmail.com> This closes #2177 from karanmehta93/master
|
Can I please be assigned this issue? |
|
@atris Please verify if there is an PR hanging out there, otherwise you can take it up! |
|
Unfortunately we can't assign github issues to people who never contributed to the repository, or maybe even to non "committers" |
|
Ok, I am working on this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
BUG REPORT
Describe the bug
During journal replay, we can encounter negative length value if there is journal corruption. Currently, due to this bug, we pass negative length to limit a buffer, which throws
IllegalArgumentException.To Reproduce
Minor bug, good to have for debugging.
Expected behavior
Error handling should be done via IOExpection, and it should be thrown instead.
The text was updated successfully, but these errors were encountered: