Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create separate module for Protobuf files #691

Closed
eolivelli opened this issue Nov 3, 2017 · 0 comments
Closed

Create separate module for Protobuf files #691

eolivelli opened this issue Nov 3, 2017 · 0 comments
Labels
area/bookie area/build area/client

Comments

@eolivelli
Copy link
Contributor

eolivelli commented Nov 3, 2017 •
edited

Protobuf compiler has some bug and created codes with warning
Seen in #670

We can move protobuf related stuff to a separate module.

Thinking about separating client-side code from bookie-side code this will be a necessary step
@eolivelli eolivelli mentioned this issue Nov 3, 2017
Closed
ivankelly added a commit to ivankelly/bookkeeper that referenced this issue Nov 9, 2017
@ivankelly
ISSUE apache#691: Move generated files into their own module
23032a4 
Upcoming changes are using GRpc in conjunction with protobuf. GRpc
generates code that created deprecation warnings when compiled with
java 8, so this change moves all generated code out to another module,
so that we don't have to turn off -Werror for all code.

In any case, at some point we should split the bookkeeper client out
from the server module, at which point we would need the definitions
on a common place.
@sijie sijie closed this as completed in e713953 Nov 11, 2017
philipsu522 pushed a commit to philipsu522/bookkeeper that referenced this issue Dec 8, 2017
@ivankelly
ISSUE apache#691: Move generated files into their own module
d5f715d 
Upcoming changes are using GRpc in conjunction with protobuf. GRpc
generates code that created deprecation warnings when compiled with
java 8, so this change moves all generated code out to another module,
so that we don't have to turn off -Werror for all code.

In any case, at some point we should split the bookkeeper client out
from the server module, at which point we would need the definitions
on a common place.

Author: Ivan Kelly <ivank@apache.org>

Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Jia Zhai <None>, Sijie Guo <sijie@apache.org>

This closes apache#711 from ivankelly/proto-module, closes apache#691
aojea pushed a commit to aojea/bookkeeper that referenced this issue Dec 16, 2017
@ivankelly @aojea
ISSUE apache#691: Move generated files into their own module
823fb89 
Upcoming changes are using GRpc in conjunction with protobuf. GRpc
generates code that created deprecation warnings when compiled with
java 8, so this change moves all generated code out to another module,
so that we don't have to turn off -Werror for all code.

In any case, at some point we should split the bookkeeper client out
from the server module, at which point we would need the definitions
on a common place.

Author: Ivan Kelly <ivank@apache.org>

Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Jia Zhai <None>, Sijie Guo <sijie@apache.org>

This closes apache#711 from ivankelly/proto-module, closes apache#691
ivankelly added a commit to ivankelly/bookkeeper that referenced this issue Mar 27, 2018
@ivankelly
ISSUE apache#691: Move generated files into their own module
0f39565 
Upcoming changes are using GRpc in conjunction with protobuf. GRpc
generates code that created deprecation warnings when compiled with
java 8, so this change moves all generated code out to another module,
so that we don't have to turn off -Werror for all code.

In any case, at some point we should split the bookkeeper client out
from the server module, at which point we would need the definitions
on a common place.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/bookie area/build area/client
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eolivelli