ISSUE #691: Move generated files into their own module #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upcoming changes are using GRpc in conjunction with protobuf. GRpc generates code that created deprecation warnings when compiled with java 8, so this change moves all generated code out to another module, so that we don't have to turn off -Werror for all code. In any case, at some point we should split the bookkeeper client out from the server module, at which point we would need the definitions on a common place.
eolivelli
requested changes
Nov 9, 2017
| <artifactId>protobuf-java</artifactId> | ||
| <version>${protobuf.version}</version> | ||
| <scope>compile</scope> | ||
| <groupId>org.apache.bookkeeper</groupId> |
There was a problem hiding this comment.
What about project.parent.grouiId?
There was a problem hiding this comment.
We don't use it for common. We should be consistent IMO.
bookkeeper-proto/pom.xml
Outdated
| <name>Apache BookKeeper :: Wire Protocols</name> | ||
| <properties> | ||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| <project.libdir>${basedir}/lib</project.libdir> |
|
FAILURE --none-- |
sijie
reviewed
Nov 9, 2017
bookkeeper-proto/pom.xml
Outdated
| <version>4.6.0-SNAPSHOT</version> | ||
| </parent> | ||
| <artifactId>bookkeeper-proto</artifactId> | ||
| <name>Apache BookKeeper :: Wire Protocols</name> |
There was a problem hiding this comment.
it is not just wire protocols. it also contain metadata protobuf definitions. we need to change it to "Protocols".
|
@eolivelli Addressed comments in latest push |
|
FAILURE --none-- |
sijie
approved these changes
Nov 10, 2017
philipsu522
pushed a commit
to philipsu522/bookkeeper
that referenced
this pull request
Dec 8, 2017
Upcoming changes are using GRpc in conjunction with protobuf. GRpc generates code that created deprecation warnings when compiled with java 8, so this change moves all generated code out to another module, so that we don't have to turn off -Werror for all code. In any case, at some point we should split the bookkeeper client out from the server module, at which point we would need the definitions on a common place. Author: Ivan Kelly <ivank@apache.org> Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Jia Zhai <None>, Sijie Guo <sijie@apache.org> This closes apache#711 from ivankelly/proto-module, closes apache#691
aojea
pushed a commit
to aojea/bookkeeper
that referenced
this pull request
Dec 16, 2017
Upcoming changes are using GRpc in conjunction with protobuf. GRpc generates code that created deprecation warnings when compiled with java 8, so this change moves all generated code out to another module, so that we don't have to turn off -Werror for all code. In any case, at some point we should split the bookkeeper client out from the server module, at which point we would need the definitions on a common place. Author: Ivan Kelly <ivank@apache.org> Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Jia Zhai <None>, Sijie Guo <sijie@apache.org> This closes apache#711 from ivankelly/proto-module, closes apache#691
athanatos
pushed a commit
to athanatos/bookkeeper
that referenced
this pull request
Jan 25, 2019
Hopefully this will fix the findBugs issue on master in the right way. lvfangmin hanm Please validate. Author: Andor Molnar <andor@apache.org> Reviewers: Michael Han <hanm@apache.org>, Enrico Olivelli <eolivelli@gmail.com> Closes apache#711 from anmolnar/ZOOKEEPER-3177
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upcoming changes are using GRpc in conjunction with protobuf. GRpc
generates code that created deprecation warnings when compiled with
java 8, so this change moves all generated code out to another module,
so that we don't have to turn off -Werror for all code.
In any case, at some point we should split the bookkeeper client out
from the server module, at which point we would need the definitions
on a common place.