ISSUE #1075: Add a noop digest implentation #1087
Conversation
|
|
||
| @Override | ||
| int getMacCodeLength() { | ||
| return 8; |
There was a problem hiding this comment.
any reason why a dummy digest manager needs a 8 bytes here? can't we just make it 0? the digest here is anyway useless, no?
There was a problem hiding this comment.
Not sure. Perhaps there is value in emulating the size overhead? @jvrao Thoughts?
There was a problem hiding this comment.
I really don't really recall why we made up the digest and kept it at 8. Maybe tried to keep the payload size in sync with CRC32.
There was a problem hiding this comment.
@jvrao any idea to waste extra 4 bytes, if it is not even used.
There was a problem hiding this comment.
@jvrao I'll switch it to an empty payload.
athanatos
force-pushed
the
forupstream/misc/dummy
branch
from
850bc3e
to
3c23fb5
Compare
|
@eolivelli Repushed with new api test. |
athanatos
force-pushed
the
forupstream/misc/dummy
branch
from
3c23fb5
to
960f0bb
Compare
|
@eolivelli please review this since you were involved in this PR |
| @Test | ||
| public void testLedgerDigests() throws Exception { | ||
| DigestType[] types = new DigestType[] { | ||
| DigestType.CRC32, |
There was a problem hiding this comment.
Sine this is an enum we should use DigestType.values() so that we are sure to cover new types in the future
This digest will add a predefined digest key without actually computing it. This can be used for testing or in situations/use-cases where digest is considered overhead. (@bug W-3245776@) Signed-off-by: Venkateswararao Jujjuri (JV) <vjujjuri@salesforce.com> [Adapted to current patch, added tests] Signed-off-by: Samuel Just <sjust@salesforce.com>
athanatos
force-pushed
the
forupstream/misc/dummy
branch
from
960f0bb
to
9fdd7fc
Compare
|
@eolivelli Done. |
|
ping @eolivelli |
|
retest this please |
1 similar comment
|
retest this please |
|
Can one of the admins verify this patch? |
|
retrigger travis ci build |
|
retest this please |
This digest will add a predefined digest key without actually computing
it. This can be used for testing or in situations/use-cases where digest
is considered overhead.
(@bug W-3245776@)
Signed-off-by: Venkateswararao Jujjuri (JV) vjujjuri@salesforce.com
[Adapted to current patch]
Signed-off-by: Samuel Just sjust@salesforce.com