Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide memory & gc options in bookkeeper script #1342

Closed
wants to merge 3 commits into from

Conversation

sijie
Copy link
Member

@sijie sijie commented Apr 13, 2018

Descriptions of the changes in this PR:

It is convenient to provide MEM_OPTS and GC_OPTS in bookkeeper script and bkenv.sh to allow overriding jvm settings through.


Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

If this PR is a BookKeeper Proposal (BP):

  • Make sure the PR title is formatted like:
    <BP-#>: Description of bookkeeper proposal
    e.g. BP-1: 64 bits ledger is support
  • Attach the master issue link in the description of this PR.
  • Attach the google doc link if the BP is written in Google Doc.

Otherwise:

  • Make sure the PR title is formatted like:
    <Issue #>: Description of pull request
    e.g. Issue 123: Description ...
  • Make sure tests pass via mvn clean apache-rat:check install spotbugs:check.
  • Replace <Issue #> in the title with the actual Issue number.

It is convinient to provide `MEM_OPTS` and `GC_OPTS` in bookkeeper script and bkenv.sh to allow overriding jvm settings through.
@sijie sijie added this to the 4.8.0 milestone Apr 13, 2018
@sijie sijie self-assigned this Apr 13, 2018
@sijie sijie requested a review from merlimat April 13, 2018 21:38
@eolivelli
Copy link
Contributor

Looks good.

As you are working on this can you take a look at adding JAVA_JDK_OPT and add jdk internal module 'opens' to netty and orur codebase in order to hide 'illegal reflective access' warnings while running on jdk10?

I can do in a follow up change if you do not have time

@sijie
Copy link
Member Author

sijie commented Apr 14, 2018

dk internal module 'opens' to netty and orur codebase in order to hide 'illegal reflective access' warnings while running on jdk10?

Please do this as a separate issue. I don't use jdk10, which I can't verify any changes.

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 lgtm

@sijie
Copy link
Member Author

sijie commented Apr 15, 2018

retest this please

@sijie
Copy link
Member Author

sijie commented Apr 17, 2018

retest this please

@sijie sijie closed this in 1242e37 Apr 17, 2018
@sijie sijie deleted the gc_settings branch July 16, 2018 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants