OrderedScheduler#chooseThread(key) handle null key #1372
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
eolivelli
approved these changes
Apr 28, 2018
|
retest this please |
jvrao
reviewed
Apr 30, 2018
| return threads[rand.nextInt(threads.length)]; | ||
| } else { | ||
| return threads[MathUtils.signSafeMod(orderingKey.hashCode(), threads.length)]; | ||
| } |
There was a problem hiding this comment.
Looks fine, but wondering what is the usecase of this? I worry it might mask bugs as ordered safe executor is an absolute must to protect the correctness (wherever it is needed). So callers need to know what they are doing.
There was a problem hiding this comment.
it is for convenience, so in the caller, I don't have to do if (orderKey != null) chooseThread(orderKey); else chooseThread(..). I can have a separate util function to do that, but I feel it is better to do it at the executor level.
|
retest this please |
sijie
added a commit
that referenced
this pull request
Apr 30, 2018
Descriptions of the changes in this PR: *Motivation* It is more convenient if OrderedScheduler#chooseThread(key) can handle null key. so the applications who is using #chooseThread don't need to worry which method to choose - `chooseThread()` vs `chooseThread(key)`. *Solution* in `chooseThread(key)`, fallback to randomly pickup a thread if key is null. Author: Sijie Guo <sijie@apache.org> Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Jia Zhai <None> This closes #1372 from sijie/order_scheduler_null_key (cherry picked from commit 1f0f92c) Signed-off-by: Sijie Guo <sijie@apache.org>
reddycharan
pushed a commit
to reddycharan/bookkeeper
that referenced
this pull request
Oct 17, 2018
Descriptions of the changes in this PR: *Motivation* It is more convenient if OrderedScheduler#chooseThread(key) can handle null key. so the applications who is using #chooseThread don't need to worry which method to choose - `chooseThread()` vs `chooseThread(key)`. *Solution* in `chooseThread(key)`, fallback to randomly pickup a thread if key is null. Author: Sijie Guo <sijie@apache.org> Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Jia Zhai <None> This closes apache#1372 from sijie/order_scheduler_null_key (cherry picked from commit 1f0f92c) Signed-off-by: Sijie Guo <sijie@apache.org> Signed-off-by: JV Jujjuri <vjujjuri@salesforce.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
Motivation
It is more convenient if OrderedScheduler#chooseThread(key) can handle null key. so the applications who is using #chooseThread don't need to worry which method to choose -
chooseThread()vschooseThread(key).Solution
in
chooseThread(key), fallback to randomly pickup a thread if key is null.