Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BOOKKEEPER-1071: Use per connection instances of request encoder/decoder #170

Closed
wants to merge 1 commit into from

Conversation

merlimat
Copy link
Contributor

@merlimat merlimat commented Jun 1, 2017

No description provided.

@merlimat
Copy link
Contributor Author

merlimat commented Jun 1, 2017

There seems to be some problem in Jenkins since the build is immediately failing:

...
Setting MAVEN_3_3_3_HOME=/home/jenkins/tools/maven/apache-maven-3.3.3
[bookkeeper-master-git-pullrequest] $ /bin/bash /tmp/hudson6425132611346733334.sh
/tmp/hudson6425132611346733334.sh: line 8: mvn: command not found
Build step 'Execute shell' marked build as failure
[FINDBUGS] Skipping publisher since build result is FAILURE

@sijie
Copy link
Member

sijie commented Jun 1, 2017

checking the jenkins build now

@sijie
Copy link
Member

sijie commented Jun 1, 2017

Hmm. I am not really sure about the error here.

@eolivelli - did you change any settings on hudson? The error message seems to be related to hudson.

Copy link
Member

@sijie sijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@eolivelli
Copy link
Contributor

No I only changed master job not the one for prs.
I will check too asap

@sijie
Copy link
Member

sijie commented Jun 1, 2017

I created a new maven-based job (the old one is using customized shell script). It seems to be working, need to adjust some build commands. https://builds.apache.org/job/bookkeeper-precommit-pullrequest/1/console

@sijie
Copy link
Member

sijie commented Jun 1, 2017

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@sijie
Copy link
Member

sijie commented Jun 1, 2017

https://builds.apache.org/job/bookkeeper-precommit-pullrequest/4/console it passed. merging this change now.

@asfgit asfgit closed this in da70648 Jun 1, 2017
revans2 pushed a commit to YahooArchive/bookkeeper that referenced this pull request Jun 21, 2017
YBK-154: Addign sleep after finding free port so the OS has time to r…
revans2 pushed a commit to YahooArchive/bookkeeper that referenced this pull request Jun 21, 2017
YBK-154: Addign sleep after finding free port so the OS has time to r…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants