BOOKKEEPER-1088: Ledger Recovery (part-3) - Add a ReadEntryListener to callback on individual request #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this change is the first part of improving bookkeeper recovery. it is basically a refactor change, which: - abstract an interface for LedgerEntryRequest in PendingReadOp - rename current implementation to SequenceReadRequest, which read the entry in the sequence of quorum. RB_ID=266137
…est in PendingReadOp - add a parallel reading request in PendingReadOp - allow PendingReadOp to configure whether to do parallel reading or not - add flag in ClientConfiguration to allow configuring whether to do parallel reading in LedgerRecoveryOp or not. RB_ID=266139
…callback on individual request. - add read entry listener which allow doing batch read, but callback on individual entries in sequence. so in recovery op, we could issue batch reads, then on each individual callback do add entry and stop when received NoSuchEntry. RB_ID=266143
|
LGTM |
|
LGTM +1 |
sijie
changed the title
asfgit
pushed a commit
that referenced
this pull request
Jun 21, 2017
…er recovery This change is based on #178 - (you can review git sha 82f73ef) bookkeeper recovery improvement (part-4): allow batch reading in ledger recovery - enable batch read in ledger recovery, so we could parallel reading to improve recovery time. RB_ID=266145 Author: Sijie Guo <sijieg@twitter.com> Author: Sijie Guo <sijie@apache.org> Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Jia Zhai <None>, Matteo Merli <mmerli@apache.org> This closes #181 from sijie/recovery_improvements_part4
asfgit
pushed a commit
that referenced
this pull request
Jun 21, 2017
This change is based #178 - (you can review git sha 40ca8c2) bookkeeper: LAC piggyback at read response - bookie server changes * cache maximum lac in file info * provide getLastAddConfirmed & setLastAddConfirmed in ledger storage * addEntry will set its lac thru setLastAddConfirmed * readEntry will read latest lac and piggyback - client change * check whether the response has lac piggybacked, if there is lac update lac in its corresponding ledger handle. Author: Sijie Guo <sijie@apache.org> Author: Sijie Guo <sijieg@twitter.com> Reviewers: Jia Zhai <None>, Matteo Merli <mmerli@apache.org> This closes #180 from sijie/piggyback_lac
revans2
pushed a commit
to revans2/bookkeeper
that referenced
this pull request
Oct 11, 2017
YBK-3: Re-enabling skipped tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS CHANGE IS BASED ON #177 (you can review 868a3c8 for the only change that belongs to BOOKKEEPER-1088).
bookkeeper recovery improvement (part-3): add a ReadEntryListener to callback on individual request.