BOOKKEEPER-1919: putEntryOffset translate FileInfoDeletedException #1950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IndexInMemPageMgr should translate FileInfoDeletedException into NoLedgerException as expected by users like InterleavedLedgerStorage.updateEntriesLocations and EntryMemTable.flushSnapshot. Signed-off-by: Samuel Just <sjust@salesforce.com>
sijie
approved these changes
Feb 19, 2019
eolivelli
approved these changes
Feb 19, 2019
There was a problem hiding this comment.
+1 looks good.
I hope we are not adding a new flaky test.
But if you managed to reproduce the issue with that case I feel this test has a value.
I am not sure how to reproduce it in an other way
cc @ivankelly
|
This is to be cherry picked to 4.9, not sure it is worth to cherry pick to 4.7 or 4.8 |
|
sorry I had closed this PR by mistake |
|
It was able to reproduce the problem and shouldn't be flaky (it's more likely to exhibit false negatives). |
|
retest |
|
run bookkeeper-server bookie tests |
|
run integration tests |
sijie
pushed a commit
that referenced
this pull request
Feb 20, 2019
IndexInMemPageMgr should translate FileInfoDeletedException into NoLedgerException as expected by users like InterleavedLedgerStorage.updateEntriesLocations and EntryMemTable.flushSnapshot. Signed-off-by: Samuel Just <sjustsalesforce.com> Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Sijie Guo <sijie@apache.org> This closes #1950 from athanatos/forupstream/wip-1919
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IndexInMemPageMgr should translate FileInfoDeletedException into
NoLedgerException as expected by users like
InterleavedLedgerStorage.updateEntriesLocations and
EntryMemTable.flushSnapshot.
Signed-off-by: Samuel Just sjust@salesforce.com