-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BOOKKEEPER-1919: putEntryOffset translate FileInfoDeletedException #1950
Conversation
IndexInMemPageMgr should translate FileInfoDeletedException into NoLedgerException as expected by users like InterleavedLedgerStorage.updateEntriesLocations and EntryMemTable.flushSnapshot. Signed-off-by: Samuel Just <sjust@salesforce.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 looks good.
I hope we are not adding a new flaky test.
But if you managed to reproduce the issue with that case I feel this test has a value.
I am not sure how to reproduce it in an other way
cc @ivankelly
This is to be cherry picked to 4.9, not sure it is worth to cherry pick to 4.7 or 4.8 |
sorry I had closed this PR by mistake |
It was able to reproduce the problem and shouldn't be flaky (it's more likely to exhibit false negatives). |
retest |
run bookkeeper-server bookie tests |
run integration tests |
IndexInMemPageMgr should translate FileInfoDeletedException into NoLedgerException as expected by users like InterleavedLedgerStorage.updateEntriesLocations and EntryMemTable.flushSnapshot. Signed-off-by: Samuel Just <sjustsalesforce.com> Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Sijie Guo <sijie@apache.org> This closes #1950 from athanatos/forupstream/wip-1919
IndexInMemPageMgr should translate FileInfoDeletedException into
NoLedgerException as expected by users like
InterleavedLedgerStorage.updateEntriesLocations and
EntryMemTable.flushSnapshot.
Signed-off-by: Samuel Just sjust@salesforce.com