Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed failing tests for /stream. #2551

Closed
wants to merge 1 commit into from

Conversation

dlg99
Copy link
Contributor

@dlg99 dlg99 commented Jan 26, 2021

Descriptions of the changes in this PR:

Fixed tests for /stream, RocksDB initialization.

Motivation

Tests were failing with " “java.lang.UnsatisfiedLinkError: 'long org.rocksdb.LRUCache.newLRUCache(long, int, boolean, double)'”".

Changes

Fixed following suggestion form facebook/rocksdb#6789
Added
static { RocksDB.loadLibrary(); }
to extract the native library from the jar file etc.

Master Issue: #2550


In order to uphold a high standard for quality for code contributions, Apache BookKeeper runs various precommit
checks for pull requests. A pull request can only be merged when it passes precommit checks.


Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

If this PR is a BookKeeper Proposal (BP):

  • Make sure the PR title is formatted like:
    <BP-#>: Description of bookkeeper proposal
    e.g. BP-1: 64 bits ledger is support
  • Attach the master issue link in the description of this PR.
  • Attach the google doc link if the BP is written in Google Doc.

Otherwise:

  • Make sure the PR title is formatted like:
    <Issue #>: Description of pull request
    e.g. Issue 123: Description ...
  • Make sure tests pass via mvn clean apache-rat:check install spotbugs:check.
  • Replace <Issue #> in the title with the actual Issue number.

Tests were failing with " “java.lang.UnsatisfiedLinkError: 'long org.rocksdb.LRUCache.newLRUCache(long, int, boolean, double)'”".
Fixed following suggestion form facebook/rocksdb#6789
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Can you please create the PR against master branch?
we usually merge to master and cherry pick to other branches.
The script does it automatically

@eolivelli
Copy link
Contributor

@lhotari we should also investigate why stream tests are not running on CI

@dlg99
Copy link
Contributor Author

dlg99 commented Jan 26, 2021

@eolivelli stream tests need "-DstreamTests" flag to run as defined in pom; while stream/statelib/ tests are fast, full stream/ test run (includes distributed logs) takes a lot of time, I guess they were disabled by default to speed the build up.

@eolivelli
Copy link
Contributor

We should add a new CI workflow to run stream tests (as part of another PR).
I can do it tomorrow if you prefer. Thanks for the pointer

@eolivelli eolivelli closed this Jan 27, 2021
eolivelli pushed a commit that referenced this pull request Jan 28, 2021
Descriptions of the changes in this PR:

Fixed tests for /stream, RocksDB initialization.
Same as #2551 but for master branch

### Motivation

Tests were failing with " “java.lang.UnsatisfiedLinkError: 'long org.rocksdb.LRUCache.newLRUCache(long, int, boolean, double)'”".

### Changes

Fixed following suggestion form facebook/rocksdb#6789
Added
`    static {
        RocksDB.loadLibrary();
    }`
to extract the native library from the jar file etc.

Master Issue: #2550




Reviewers: Enrico Olivelli <eolivelli@gmail.com>

This closes #2554 from dlg99/master-streams-tests
eolivelli pushed a commit that referenced this pull request Jan 28, 2021
Descriptions of the changes in this PR:

Fixed tests for /stream, RocksDB initialization.
Same as #2551 but for master branch

### Motivation

Tests were failing with " “java.lang.UnsatisfiedLinkError: 'long org.rocksdb.LRUCache.newLRUCache(long, int, boolean, double)'”".

### Changes

Fixed following suggestion form facebook/rocksdb#6789
Added
`    static {
        RocksDB.loadLibrary();
    }`
to extract the native library from the jar file etc.

Master Issue: #2550

Reviewers: Enrico Olivelli <eolivelli@gmail.com>

This closes #2554 from dlg99/master-streams-tests

(cherry picked from commit 73b4cd4)
Signed-off-by: Enrico Olivelli <eolivelli@apache.org>
eolivelli pushed a commit that referenced this pull request Jan 28, 2021
Descriptions of the changes in this PR:

Fixed tests for /stream, RocksDB initialization.
Same as #2551 but for master branch

### Motivation

Tests were failing with " “java.lang.UnsatisfiedLinkError: 'long org.rocksdb.LRUCache.newLRUCache(long, int, boolean, double)'”".

### Changes

Fixed following suggestion form facebook/rocksdb#6789
Added
`    static {
        RocksDB.loadLibrary();
    }`
to extract the native library from the jar file etc.

Master Issue: #2550

Reviewers: Enrico Olivelli <eolivelli@gmail.com>

This closes #2554 from dlg99/master-streams-tests

(cherry picked from commit 73b4cd4)
Signed-off-by: Enrico Olivelli <eolivelli@apache.org>
eolivelli pushed a commit that referenced this pull request Jan 28, 2021
Descriptions of the changes in this PR:

Fixed tests for /stream, RocksDB initialization.
Same as #2551 but for master branch

### Motivation

Tests were failing with " “java.lang.UnsatisfiedLinkError: 'long org.rocksdb.LRUCache.newLRUCache(long, int, boolean, double)'”".

### Changes

Fixed following suggestion form facebook/rocksdb#6789
Added
`    static {
        RocksDB.loadLibrary();
    }`
to extract the native library from the jar file etc.

Master Issue: #2550

Reviewers: Enrico Olivelli <eolivelli@gmail.com>

This closes #2554 from dlg99/master-streams-tests

(cherry picked from commit 73b4cd4)
Signed-off-by: Enrico Olivelli <eolivelli@apache.org>
@dlg99 dlg99 deleted the branch-4.12-streams-tests branch October 14, 2021 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants