-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed failing tests for /stream. #2551
Conversation
Tests were failing with " “java.lang.UnsatisfiedLinkError: 'long org.rocksdb.LRUCache.newLRUCache(long, int, boolean, double)'”". Fixed following suggestion form facebook/rocksdb#6789
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Can you please create the PR against master branch?
we usually merge to master and cherry pick to other branches.
The script does it automatically
@lhotari we should also investigate why stream tests are not running on CI |
@eolivelli stream tests need "-DstreamTests" flag to run as defined in pom; while stream/statelib/ tests are fast, full stream/ test run (includes distributed logs) takes a lot of time, I guess they were disabled by default to speed the build up. |
We should add a new CI workflow to run stream tests (as part of another PR). |
Descriptions of the changes in this PR: Fixed tests for /stream, RocksDB initialization. Same as #2551 but for master branch ### Motivation Tests were failing with " “java.lang.UnsatisfiedLinkError: 'long org.rocksdb.LRUCache.newLRUCache(long, int, boolean, double)'”". ### Changes Fixed following suggestion form facebook/rocksdb#6789 Added ` static { RocksDB.loadLibrary(); }` to extract the native library from the jar file etc. Master Issue: #2550 Reviewers: Enrico Olivelli <eolivelli@gmail.com> This closes #2554 from dlg99/master-streams-tests
Descriptions of the changes in this PR: Fixed tests for /stream, RocksDB initialization. Same as #2551 but for master branch ### Motivation Tests were failing with " “java.lang.UnsatisfiedLinkError: 'long org.rocksdb.LRUCache.newLRUCache(long, int, boolean, double)'”". ### Changes Fixed following suggestion form facebook/rocksdb#6789 Added ` static { RocksDB.loadLibrary(); }` to extract the native library from the jar file etc. Master Issue: #2550 Reviewers: Enrico Olivelli <eolivelli@gmail.com> This closes #2554 from dlg99/master-streams-tests (cherry picked from commit 73b4cd4) Signed-off-by: Enrico Olivelli <eolivelli@apache.org>
Descriptions of the changes in this PR: Fixed tests for /stream, RocksDB initialization. Same as #2551 but for master branch ### Motivation Tests were failing with " “java.lang.UnsatisfiedLinkError: 'long org.rocksdb.LRUCache.newLRUCache(long, int, boolean, double)'”". ### Changes Fixed following suggestion form facebook/rocksdb#6789 Added ` static { RocksDB.loadLibrary(); }` to extract the native library from the jar file etc. Master Issue: #2550 Reviewers: Enrico Olivelli <eolivelli@gmail.com> This closes #2554 from dlg99/master-streams-tests (cherry picked from commit 73b4cd4) Signed-off-by: Enrico Olivelli <eolivelli@apache.org>
Descriptions of the changes in this PR: Fixed tests for /stream, RocksDB initialization. Same as #2551 but for master branch ### Motivation Tests were failing with " “java.lang.UnsatisfiedLinkError: 'long org.rocksdb.LRUCache.newLRUCache(long, int, boolean, double)'”". ### Changes Fixed following suggestion form facebook/rocksdb#6789 Added ` static { RocksDB.loadLibrary(); }` to extract the native library from the jar file etc. Master Issue: #2550 Reviewers: Enrico Olivelli <eolivelli@gmail.com> This closes #2554 from dlg99/master-streams-tests (cherry picked from commit 73b4cd4) Signed-off-by: Enrico Olivelli <eolivelli@apache.org>
Descriptions of the changes in this PR:
Fixed tests for /stream, RocksDB initialization.
Motivation
Tests were failing with " “java.lang.UnsatisfiedLinkError: 'long org.rocksdb.LRUCache.newLRUCache(long, int, boolean, double)'”".
Changes
Fixed following suggestion form facebook/rocksdb#6789
Added
static { RocksDB.loadLibrary(); }
to extract the native library from the jar file etc.
Master Issue: #2550