Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed failing tests for /stream. #2554

Merged
merged 1 commit into from
Jan 28, 2021
Merged

Fixed failing tests for /stream. #2554

merged 1 commit into from
Jan 28, 2021

Conversation

dlg99
Copy link
Contributor

@dlg99 dlg99 commented Jan 26, 2021

Descriptions of the changes in this PR:

Fixed tests for /stream, RocksDB initialization.
Same as #2551 but for master branch

Motivation

Tests were failing with " “java.lang.UnsatisfiedLinkError: 'long org.rocksdb.LRUCache.newLRUCache(long, int, boolean, double)'”".

Changes

Fixed following suggestion form facebook/rocksdb#6789
Added
static { RocksDB.loadLibrary(); }
to extract the native library from the jar file etc.

Master Issue: #2550

In order to uphold a high standard for quality for code contributions, Apache BookKeeper runs various precommit
checks for pull requests. A pull request can only be merged when it passes precommit checks.

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

If this PR is a BookKeeper Proposal (BP):

  • Make sure the PR title is formatted like:
    <BP-#>: Description of bookkeeper proposal
    e.g. BP-1: 64 bits ledger is support
  • Attach the master issue link in the description of this PR.
  • Attach the google doc link if the BP is written in Google Doc.

Otherwise:

  • Make sure the PR title is formatted like:
    <Issue #>: Description of pull request
    e.g. Issue 123: Description ...
  • Make sure tests pass via mvn clean apache-rat:check install spotbugs:check.
  • Replace <Issue #> in the title with the actual Issue number.

@dlg99 dlg99 requested a review from eolivelli January 26, 2021 21:45
@eolivelli
Copy link
Contributor

rerun-failure-tests

@dlg99
Fixed failing tests for /stream.
38a7388 
Tests were failing with " “java.lang.UnsatisfiedLinkError: 'long org.rocksdb.LRUCache.newLRUCache(long, int, boolean, double)'”".
Fixed following suggestion form facebook/rocksdb#6789
@dlg99
Copy link
Contributor Author

dlg99 commented Jan 27, 2021

rerun-failure-tests

eolivelli
eolivelli approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eolivelli eolivelli added this to the 4.13.0 milestone Jan 28, 2021
@eolivelli eolivelli merged commit 73b4cd4 into apache:master Jan 28, 2021
eolivelli pushed a commit that referenced this pull request Jan 28, 2021
@dlg99 @eolivelli
Fixed failing tests for /stream.
5ef49fa 
Descriptions of the changes in this PR:

Fixed tests for /stream, RocksDB initialization.
Same as #2551 but for master branch

### Motivation

Tests were failing with " “java.lang.UnsatisfiedLinkError: 'long org.rocksdb.LRUCache.newLRUCache(long, int, boolean, double)'”".

### Changes

Fixed following suggestion form facebook/rocksdb#6789
Added
`    static {
        RocksDB.loadLibrary();
    }`
to extract the native library from the jar file etc.

Master Issue: #2550

Reviewers: Enrico Olivelli <eolivelli@gmail.com>

This closes #2554 from dlg99/master-streams-tests

(cherry picked from commit 73b4cd4)
Signed-off-by: Enrico Olivelli <eolivelli@apache.org>
eolivelli pushed a commit that referenced this pull request Jan 28, 2021
@dlg99 @eolivelli
Fixed failing tests for /stream.
696c057 
Descriptions of the changes in this PR:

Fixed tests for /stream, RocksDB initialization.
Same as #2551 but for master branch

### Motivation

Tests were failing with " “java.lang.UnsatisfiedLinkError: 'long org.rocksdb.LRUCache.newLRUCache(long, int, boolean, double)'”".

### Changes

Fixed following suggestion form facebook/rocksdb#6789
Added
`    static {
        RocksDB.loadLibrary();
    }`
to extract the native library from the jar file etc.

Master Issue: #2550

Reviewers: Enrico Olivelli <eolivelli@gmail.com>

This closes #2554 from dlg99/master-streams-tests

(cherry picked from commit 73b4cd4)
Signed-off-by: Enrico Olivelli <eolivelli@apache.org>
eolivelli pushed a commit that referenced this pull request Jan 28, 2021
@dlg99 @eolivelli
Fixed failing tests for /stream.
f21c801 
Descriptions of the changes in this PR:

Fixed tests for /stream, RocksDB initialization.
Same as #2551 but for master branch

### Motivation

Tests were failing with " “java.lang.UnsatisfiedLinkError: 'long org.rocksdb.LRUCache.newLRUCache(long, int, boolean, double)'”".

### Changes

Fixed following suggestion form facebook/rocksdb#6789
Added
`    static {
        RocksDB.loadLibrary();
    }`
to extract the native library from the jar file etc.

Master Issue: #2550

Reviewers: Enrico Olivelli <eolivelli@gmail.com>

This closes #2554 from dlg99/master-streams-tests

(cherry picked from commit 73b4cd4)
Signed-off-by: Enrico Olivelli <eolivelli@apache.org>
@eolivelli eolivelli added the area/tableservice changes related to table service label Jan 28, 2021
@dlg99 dlg99 deleted the master-streams-tests branch October 14, 2021 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eolivelli eolivelli eolivelli approved these changes

Assignees

@dlg99 dlg99

Labels
area/tableservice changes related to table service area/tests release/4.10.1 release/4.11.2 release/4.12.2 release/4.13.0 type/bug
Projects
None yet
Milestone
4.13.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dlg99 @eolivelli