Fix the PendingAddOp is not recycled when LedgerHandler closed #3321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- **Motivation** When adding an entry into a bookie, the entry data lifecycle is handled by the bookie client. The data buffer will be released after receiving a corresponding response from the bookie server. So the user doesn't care about the entry buffer releasing. But when the ledgerHandler is closed, the PendingAddOp is not recycled which leads to the data buffer never being released. We should release that after the callback executed.
eolivelli
approved these changes
Jun 7, 2022
merlimat
approved these changes
Jun 8, 2022
lordcheng10
approved these changes
Jun 8, 2022
eolivelli
pushed a commit
that referenced
this pull request
Jun 8, 2022
--- **Motivation** When adding an entry into a bookie, the entry data lifecycle is handled by the bookie client. The data buffer will be released after receiving a corresponding response from the bookie server. So the user doesn't care about the entry buffer releasing. But when the ledgerHandler is closed, the PendingAddOp is not recycled which leads to the data buffer never being released. We should release that after the callback executed. (cherry picked from commit 3d01e6e)
|
I have cherry-picked this change to branch-4.15 and branch-4.14 |
eolivelli
pushed a commit
that referenced
this pull request
Jun 8, 2022
--- **Motivation** When adding an entry into a bookie, the entry data lifecycle is handled by the bookie client. The data buffer will be released after receiving a corresponding response from the bookie server. So the user doesn't care about the entry buffer releasing. But when the ledgerHandler is closed, the PendingAddOp is not recycled which leads to the data buffer never being released. We should release that after the callback executed. (cherry picked from commit 3d01e6e)
eolivelli
pushed a commit
to datastax/bookkeeper
that referenced
this pull request
Jun 8, 2022
…e#3321) --- **Motivation** When adding an entry into a bookie, the entry data lifecycle is handled by the bookie client. The data buffer will be released after receiving a corresponding response from the bookie server. So the user doesn't care about the entry buffer releasing. But when the ledgerHandler is closed, the PendingAddOp is not recycled which leads to the data buffer never being released. We should release that after the callback executed. (cherry picked from commit 3d01e6e)
Shawyeok
pushed a commit
to Shawyeok/bookkeeper
that referenced
this pull request
Oct 21, 2022
…e#3321) --- **Motivation** When adding an entry into a bookie, the entry data lifecycle is handled by the bookie client. The data buffer will be released after receiving a corresponding response from the bookie server. So the user doesn't care about the entry buffer releasing. But when the ledgerHandler is closed, the PendingAddOp is not recycled which leads to the data buffer never being released. We should release that after the callback executed. (cherry picked from commit 3d01e6e)
2 tasks
hangc0276
pushed a commit
that referenced
this pull request
Nov 14, 2022
…gerHandleAdv (#3621) Descriptions of the changes in this PR: Apply recycle logic during add entry creation but ledger close to LedgerHandleAdv ### Motivation This pr is a supplement to #3321 If I understand correctly. these recycled logic should be applied to LedgerHandleAdv (cherry picked from commit 0d2fbe4)
nicoloboschi
pushed a commit
to datastax/bookkeeper
that referenced
this pull request
Jan 11, 2023
…gerHandleAdv (apache#3621) Descriptions of the changes in this PR: Apply recycle logic during add entry creation but ledger close to LedgerHandleAdv ### Motivation This pr is a supplement to apache#3321 If I understand correctly. these recycled logic should be applied to LedgerHandleAdv (cherry picked from commit 0d2fbe4) (cherry picked from commit b4d0be2)
yaalsn
pushed a commit
to yaalsn/bookkeeper
that referenced
this pull request
Jan 30, 2023
…gerHandleAdv (apache#3621) Descriptions of the changes in this PR: Apply recycle logic during add entry creation but ledger close to LedgerHandleAdv ### Motivation This pr is a supplement to apache#3321 If I understand correctly. these recycled logic should be applied to LedgerHandleAdv
zymap
pushed a commit
that referenced
this pull request
Feb 16, 2023
…gerHandleAdv (#3621) Descriptions of the changes in this PR: Apply recycle logic during add entry creation but ledger close to LedgerHandleAdv ### Motivation This pr is a supplement to #3321 If I understand correctly. these recycled logic should be applied to LedgerHandleAdv (cherry picked from commit 0d2fbe4)
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
…e#3321) --- **Motivation** When adding an entry into a bookie, the entry data lifecycle is handled by the bookie client. The data buffer will be released after receiving a corresponding response from the bookie server. So the user doesn't care about the entry buffer releasing. But when the ledgerHandler is closed, the PendingAddOp is not recycled which leads to the data buffer never being released. We should release that after the callback executed.
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
…gerHandleAdv (apache#3621) Descriptions of the changes in this PR: Apply recycle logic during add entry creation but ledger close to LedgerHandleAdv ### Motivation This pr is a supplement to apache#3321 If I understand correctly. these recycled logic should be applied to LedgerHandleAdv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When adding an entry into a bookie, the entry data lifecycle
is handled by the bookie client. The data buffer will be
released after receiving a corresponding response from the
bookie server. So the user doesn't care about the entry
buffer releasing.
But when the ledgerHandler is closed, the PendingAddOp is not
recycled which leads to the data buffer never being released.
We should release that after the callback is executed.