-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply recycle logic during add entry creation but ledger close to LedgerHandleAdv #3621
Merged
hangc0276
merged 1 commit into
apache:master
from
zhaohaidao:hotfix/apply-recycle-logic-to-ledger-handle-adv
Nov 14, 2022
Merged
Apply recycle logic during add entry creation but ledger close to LedgerHandleAdv #3621
hangc0276
merged 1 commit into
apache:master
from
zhaohaidao:hotfix/apply-recycle-logic-to-ledger-handle-adv
Nov 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@zymap Please have a look if you have time. |
zymap
approved these changes
Nov 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hangc0276
approved these changes
Nov 8, 2022
wenbingshen
approved these changes
Nov 8, 2022
hangc0276
pushed a commit
that referenced
this pull request
Nov 14, 2022
…gerHandleAdv (#3621) Descriptions of the changes in this PR: Apply recycle logic during add entry creation but ledger close to LedgerHandleAdv ### Motivation This pr is a supplement to #3321 If I understand correctly. these recycled logic should be applied to LedgerHandleAdv (cherry picked from commit 0d2fbe4)
nicoloboschi
pushed a commit
to datastax/bookkeeper
that referenced
this pull request
Jan 11, 2023
…gerHandleAdv (apache#3621) Descriptions of the changes in this PR: Apply recycle logic during add entry creation but ledger close to LedgerHandleAdv ### Motivation This pr is a supplement to apache#3321 If I understand correctly. these recycled logic should be applied to LedgerHandleAdv (cherry picked from commit 0d2fbe4) (cherry picked from commit b4d0be2)
yaalsn
pushed a commit
to yaalsn/bookkeeper
that referenced
this pull request
Jan 30, 2023
…gerHandleAdv (apache#3621) Descriptions of the changes in this PR: Apply recycle logic during add entry creation but ledger close to LedgerHandleAdv ### Motivation This pr is a supplement to apache#3321 If I understand correctly. these recycled logic should be applied to LedgerHandleAdv
zymap
pushed a commit
that referenced
this pull request
Feb 16, 2023
…gerHandleAdv (#3621) Descriptions of the changes in this PR: Apply recycle logic during add entry creation but ledger close to LedgerHandleAdv ### Motivation This pr is a supplement to #3321 If I understand correctly. these recycled logic should be applied to LedgerHandleAdv (cherry picked from commit 0d2fbe4)
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
…gerHandleAdv (apache#3621) Descriptions of the changes in this PR: Apply recycle logic during add entry creation but ledger close to LedgerHandleAdv ### Motivation This pr is a supplement to apache#3321 If I understand correctly. these recycled logic should be applied to LedgerHandleAdv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
Apply recycle logic during add entry creation but ledger close to LedgerHandleAdv
Motivation
This pr is a supplement to #3321
If I understand correctly. these recycled logic should be applied to LedgerHandleAdv