Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply recycle logic during add entry creation but ledger close to LedgerHandleAdv #3621

Conversation

zhaohaidao
Copy link
Contributor

@zhaohaidao zhaohaidao commented Nov 7, 2022

Descriptions of the changes in this PR:
Apply recycle logic during add entry creation but ledger close to LedgerHandleAdv

Motivation

This pr is a supplement to #3321
If I understand correctly. these recycled logic should be applied to LedgerHandleAdv


In order to uphold a high standard for quality for code contributions, Apache BookKeeper runs various precommit
checks for pull requests. A pull request can only be merged when it passes precommit checks.


Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

If this PR is a BookKeeper Proposal (BP):

  • Make sure the PR title is formatted like:
    <BP-#>: Description of bookkeeper proposal
    e.g. BP-1: 64 bits ledger is support
  • Attach the master issue link in the description of this PR.
  • Attach the google doc link if the BP is written in Google Doc.

Otherwise:

  • Make sure the PR title is formatted like:
    <Issue #>: Description of pull request
    e.g. Issue 123: Description ...
  • Make sure tests pass via mvn clean apache-rat:check install spotbugs:check.
  • Replace <Issue #> in the title with the actual Issue number.

@zhaohaidao
Copy link
Contributor Author

@zymap Please have a look if you have time.

@zymap zymap assigned zymap and zhaohaidao and unassigned zymap Nov 8, 2022
@zymap zymap added this to the 4.16.0 milestone Nov 8, 2022
Copy link
Member

@zymap zymap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hangc0276 hangc0276 merged commit 0d2fbe4 into apache:master Nov 14, 2022
hangc0276 pushed a commit that referenced this pull request Nov 14, 2022
…gerHandleAdv (#3621)

Descriptions of the changes in this PR:
Apply recycle logic during add entry creation but ledger close to LedgerHandleAdv

### Motivation
This pr is a supplement to #3321
If I understand correctly. these recycled logic should be applied to LedgerHandleAdv

(cherry picked from commit 0d2fbe4)
nicoloboschi pushed a commit to datastax/bookkeeper that referenced this pull request Jan 11, 2023
…gerHandleAdv (apache#3621)

Descriptions of the changes in this PR:
Apply recycle logic during add entry creation but ledger close to LedgerHandleAdv

### Motivation
This pr is a supplement to apache#3321
If I understand correctly. these recycled logic should be applied to LedgerHandleAdv

(cherry picked from commit 0d2fbe4)
(cherry picked from commit b4d0be2)
yaalsn pushed a commit to yaalsn/bookkeeper that referenced this pull request Jan 30, 2023
…gerHandleAdv (apache#3621)

Descriptions of the changes in this PR:
Apply recycle logic during add entry creation but ledger close to LedgerHandleAdv

### Motivation
This pr is a supplement to apache#3321
If I understand correctly. these recycled logic should be applied to LedgerHandleAdv
zymap pushed a commit that referenced this pull request Feb 16, 2023
…gerHandleAdv (#3621)

Descriptions of the changes in this PR:
Apply recycle logic during add entry creation but ledger close to LedgerHandleAdv

### Motivation
This pr is a supplement to #3321
If I understand correctly. these recycled logic should be applied to LedgerHandleAdv

(cherry picked from commit 0d2fbe4)
Ghatage pushed a commit to sijie/bookkeeper that referenced this pull request Jul 12, 2024
…gerHandleAdv (apache#3621)

Descriptions of the changes in this PR:
Apply recycle logic during add entry creation but ledger close to LedgerHandleAdv

### Motivation
This pr is a supplement to apache#3321
If I understand correctly. these recycled logic should be applied to LedgerHandleAdv
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants