Apply the backpressure changes on the V2 requests #3324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- *Motivation* If one bookie is slow (not down, just slow), the BK client will the acks to the user that the entries are written after the first 2 acks. In the meantime, it will keep waiting for the 3rd bookie to respond. If the bookie responds within the timeout, the entries can now be dropped from memory, otherwise the write will timeout internally and it will get replayed to a new bookie. In the V3 request, we have [server-side backpressure](apache#1410) to impact the client-side behaviors. We should apply the same changes to the V2 request. That would help this [issue](apache/pulsar#14861) to be resolved. *Modification* - Apply the change apache#1410 to V2 protocol
|
As we mentioned in this issue, broker is easy to OOM when there has one bookie slow. Broker Direct Memory: Bookie Add latency: |
|
rerun failure checks |
|
rerun failure checks |
|
rerun failure checks |
1 similar comment
|
rerun failure checks |
|
@eolivelli @merlimat Please help to take a review when you have time. Once the backpressure applies to the v2 requests, this will help to control the client's memory usage. Also can help to resolve the issue I mentioned in this issue |
eolivelli
approved these changes
Jun 15, 2022
shoothzj
approved these changes
Jun 15, 2022
zymap
added a commit
that referenced
this pull request
Jun 16, 2022
--- *Motivation* If one bookie is slow (not down, just slow), the BK client will the acks to the user that the entries are written after the first 2 acks. In the meantime, it will keep waiting for the 3rd bookie to respond. If the bookie responds within the timeout, the entries can now be dropped from memory, otherwise the write will timeout internally and it will get replayed to a new bookie. In the V3 request, we have [server-side backpressure](#1410) to impact the client-side behaviors. We should apply the same changes to the V2 request. That would help this [issue](apache/pulsar#14861) to be resolved. *Modification* - Apply the change #1410 to V2 protocol Descriptions of the changes in this PR: (cherry picked from commit 62400bd)
zymap
added a commit
that referenced
this pull request
Jun 16, 2022
--- *Motivation* If one bookie is slow (not down, just slow), the BK client will the acks to the user that the entries are written after the first 2 acks. In the meantime, it will keep waiting for the 3rd bookie to respond. If the bookie responds within the timeout, the entries can now be dropped from memory, otherwise the write will timeout internally and it will get replayed to a new bookie. In the V3 request, we have [server-side backpressure](#1410) to impact the client-side behaviors. We should apply the same changes to the V2 request. That would help this [issue](apache/pulsar#14861) to be resolved. *Modification* - Apply the change #1410 to V2 protocol Descriptions of the changes in this PR: (cherry picked from commit 62400bd)
|
Thank you! I have cherry-picked this PR to branch-4.14 and branch-4.15 |
eolivelli
pushed a commit
to datastax/bookkeeper
that referenced
this pull request
Jul 27, 2022
--- *Motivation* If one bookie is slow (not down, just slow), the BK client will the acks to the user that the entries are written after the first 2 acks. In the meantime, it will keep waiting for the 3rd bookie to respond. If the bookie responds within the timeout, the entries can now be dropped from memory, otherwise the write will timeout internally and it will get replayed to a new bookie. In the V3 request, we have [server-side backpressure](apache#1410) to impact the client-side behaviors. We should apply the same changes to the V2 request. That would help this [issue](apache/pulsar#14861) to be resolved. *Modification* - Apply the change apache#1410 to V2 protocol Descriptions of the changes in this PR: (cherry picked from commit 62400bd) (cherry picked from commit b025f7b)
lhotari
pushed a commit
to datastax/bookkeeper
that referenced
this pull request
Aug 9, 2022
--- *Motivation* If one bookie is slow (not down, just slow), the BK client will the acks to the user that the entries are written after the first 2 acks. In the meantime, it will keep waiting for the 3rd bookie to respond. If the bookie responds within the timeout, the entries can now be dropped from memory, otherwise the write will timeout internally and it will get replayed to a new bookie. In the V3 request, we have [server-side backpressure](apache#1410) to impact the client-side behaviors. We should apply the same changes to the V2 request. That would help this [issue](apache/pulsar#14861) to be resolved. *Modification* - Apply the change apache#1410 to V2 protocol Descriptions of the changes in this PR: (cherry picked from commit 62400bd) (cherry picked from commit b025f7b)
lhotari
added a commit
to lhotari/bookkeeper
that referenced
this pull request
Aug 9, 2022
- cherry-picking apache#3324 requires this backport
lhotari
added a commit
to datastax/bookkeeper
that referenced
this pull request
Aug 9, 2022
- cherry-picking apache#3324 requires this backport
lhotari
added a commit
to lhotari/bookkeeper
that referenced
this pull request
Aug 9, 2022
- cherry-picking apache#3324 requires this backport
lhotari
added a commit
to datastax/bookkeeper
that referenced
this pull request
Aug 9, 2022
- cherry-picking apache#3324 requires this backport
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
--- *Motivation* If one bookie is slow (not down, just slow), the BK client will the acks to the user that the entries are written after the first 2 acks. In the meantime, it will keep waiting for the 3rd bookie to respond. If the bookie responds within the timeout, the entries can now be dropped from memory, otherwise the write will timeout internally and it will get replayed to a new bookie. In the V3 request, we have [server-side backpressure](apache#1410) to impact the client-side behaviors. We should apply the same changes to the V2 request. That would help this [issue](apache/pulsar#14861) to be resolved. *Modification* - Apply the change apache#1410 to V2 protocol Descriptions of the changes in this PR:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If one bookie is slow (not down, just slow), the BK client
will the acks to the user that the entries are written after
the first 2 acks. In the meantime, it will keep waiting for
the 3rd bookie to respond. If the bookie responds within the
timeout, the entries can now be dropped from memory, otherwise
the write will timeout internally and it will get replayed
to a new bookie.
In the V3 request, we have server-side backpressure
to impact the client-side behaviors. We should apply the same
changes to the V2 request. That would help this issue
to be resolved.
Modification
Descriptions of the changes in this PR: