[fix][server]fix memory leak when operating ledger metadata #3662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hangc0276
reviewed
Nov 22, 2022
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/CleanupLedgerManager.java
Outdated
Show resolved
Hide resolved
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/CleanupLedgerManager.java
Outdated
Show resolved
Hide resolved
mattisonchao
approved these changes
Nov 22, 2022
dlg99
approved these changes
Nov 22, 2022
zymap
approved these changes
Nov 23, 2022
wenbingshen
approved these changes
Nov 24, 2022
added a unit test. PTAL @hangc0276 |
hangc0276
pushed a commit
that referenced
this pull request
Dec 8, 2022
* [fix][server]fix memory leak when operating ledger metadata (cherry picked from commit 109688c)
hangc0276
added
release/4.14.6
cherry-picked/branch-4.14
and removed
release/4.14.7
labels
zymap
pushed a commit
that referenced
this pull request
Feb 16, 2023
* [fix][server]fix memory leak when operating ledger metadata (cherry picked from commit 109688c)
gaozhangmin
pushed a commit
to gaozhangmin/bookkeeper
that referenced
this pull request
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There is a memory leak point in Bookkeeper client, see the following heap report:
It happens when opening a non-existent or expired ledger data. The following screen shot is memeory leak point by Eclipse Memory Analyzer.
Changes
Handle exception and clean up when promise complete exceptionally.
Master Issue: #1