Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release AddsSemaphore if version not compatible #3761

Closed

Conversation

AnonHxy
Copy link
Contributor

@AnonHxy AnonHxy commented Feb 2, 2023

Descriptions of the changes in this PR:

Motivation

Fix release AddsSemaphore if version not compatible. We should use BookieProtocol.ParsedAddRequest in server instead of BookieProtocol.AddRequest

Changes

  • Change AddRequest to ParsedAddRequest.
  • Add a test WriteEntryProcessorTest#testVersionNotCompatible to verfiy it

@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@c7cc668). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #3761   +/-   ##
=========================================
  Coverage          ?   68.14%           
  Complexity        ?     6660           
=========================================
  Files             ?      468           
  Lines             ?    40836           
  Branches          ?     5235           
=========================================
  Hits              ?    27829           
  Misses            ?    10745           
  Partials          ?     2262           
Flag Coverage Δ
bookie 39.81% <0.00%> (?)
client 44.28% <0.00%> (?)
remaining 29.39% <0.00%> (?)
replication 41.48% <0.00%> (?)
tls 21.06% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@hangc0276 hangc0276 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3746
This PR already fixed the issue.

@AnonHxy
Copy link
Contributor Author

AnonHxy commented Feb 3, 2023

This PR already fixed the issue.

OK. Thanks for your remind. I will close this PR @hangc0276

@AnonHxy AnonHxy closed this Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants