Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Branch-4.14] Revert PR#3653 and make delete entries batch size configurable #3768

Merged
merged 1 commit into from Feb 8, 2023

Conversation

hangc0276
Copy link
Contributor

Motivations

This PR is to resolve the issue #3734 in branch-4.14 by following this suggestion. #3734 (comment)

Modifications

  1. Revert Bring back deleteRange for RocksDB to improve location delete performance #3653
  2. Bring Make RocksDB delete entries batch size configurable #3646 to branch-4.14 to make delete entries batch size configurable.

@hangc0276 hangc0276 changed the title Revert PR#3653 and make delete entries batch size configurable [Branch-4.14] Revert PR#3653 and make delete entries batch size configurable Feb 7, 2023
@hangc0276 hangc0276 self-assigned this Feb 7, 2023
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hangc0276 hangc0276 merged commit e56d6d6 into apache:branch-4.14 Feb 8, 2023
nicoloboschi pushed a commit to datastax/bookkeeper that referenced this pull request Mar 13, 2023
…e#3768)

### Motivations
This PR is to resolve the issue apache#3734 in branch-4.14 by following this suggestion. apache#3734 (comment)

### Modifications
1. Revert apache#3653
2. Bring apache#3646 to branch-4.14 to make delete entries batch size configurable.

(cherry picked from commit e56d6d6)
nicoloboschi pushed a commit to datastax/bookkeeper that referenced this pull request Mar 13, 2023
…e#3768)

### Motivations
This PR is to resolve the issue apache#3734 in branch-4.14 by following this suggestion. apache#3734 (comment)

### Modifications
1. Revert apache#3653
2. Bring apache#3646 to branch-4.14 to make delete entries batch size configurable.

(cherry picked from commit e56d6d6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants