-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring back deleteRange for RocksDB to improve location delete performance #3653
Bring back deleteRange for RocksDB to improve location delete performance #3653
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great !
Looking forward to see this in 4.16.0, and probably we can port it to 4.15 branch
@eolivelli Yes, I will cherry-pick it to branch-4.14 and branch-4.15 |
…ance (#3653) The entry log location index deletion is deleted in batches one by one currently, and it will have low performance. Refer to: #3646 Matteo has introduced deleteRange API a few years ago, but rollback due to RocksDB delete ranges bug. #1620. The RocksDB bug has been addressed since 5.18.0 https://github.com/facebook/rocksdb/blob/main/HISTORY.md#5180-2018-11-30. We can bring the `deleteRange` API back to improve the entry log location deletion performance. Bring `deleteRange` API back for entry log location deletion. (cherry picked from commit 696919c)
…ance (apache#3653) ### Motivation The entry log location index deletion is deleted in batches one by one currently, and it will have low performance. Refer to: apache#3646 Matteo has introduced deleteRange API a few years ago, but rollback due to RocksDB delete ranges bug. apache#1620. The RocksDB bug has been addressed since 5.18.0 https://github.com/facebook/rocksdb/blob/main/HISTORY.md#5180-2018-11-30. We can bring the `deleteRange` API back to improve the entry log location deletion performance. ### Changes Bring `deleteRange` API back for entry log location deletion.
…ance (apache#3653) The entry log location index deletion is deleted in batches one by one currently, and it will have low performance. Refer to: apache#3646 Matteo has introduced deleteRange API a few years ago, but rollback due to RocksDB delete ranges bug. apache#1620. The RocksDB bug has been addressed since 5.18.0 https://github.com/facebook/rocksdb/blob/main/HISTORY.md#5180-2018-11-30. We can bring the `deleteRange` API back to improve the entry log location deletion performance. Bring `deleteRange` API back for entry log location deletion. (cherry picked from commit 696919c) (cherry picked from commit e159510)
…ance (apache#3653) ### Motivation The entry log location index deletion is deleted in batches one by one currently, and it will have low performance. Refer to: apache#3646 Matteo has introduced deleteRange API a few years ago, but rollback due to RocksDB delete ranges bug. apache#1620. The RocksDB bug has been addressed since 5.18.0 https://github.com/facebook/rocksdb/blob/main/HISTORY.md#5180-2018-11-30. We can bring the `deleteRange` API back to improve the entry log location deletion performance. ### Changes Bring `deleteRange` API back for entry log location deletion.
### Motivations This PR is to resolve the issue #3734 in branch-4.14 by following this suggestion. #3734 (comment) ### Modifications 1. Revert #3653 2. Bring #3646 to branch-4.14 to make delete entries batch size configurable.
…e#3768) ### Motivations This PR is to resolve the issue apache#3734 in branch-4.14 by following this suggestion. apache#3734 (comment) ### Modifications 1. Revert apache#3653 2. Bring apache#3646 to branch-4.14 to make delete entries batch size configurable. (cherry picked from commit e56d6d6)
…e#3768) ### Motivations This PR is to resolve the issue apache#3734 in branch-4.14 by following this suggestion. apache#3734 (comment) ### Modifications 1. Revert apache#3653 2. Bring apache#3646 to branch-4.14 to make delete entries batch size configurable. (cherry picked from commit e56d6d6)
…ance (apache#3653) ### Motivation The entry log location index deletion is deleted in batches one by one currently, and it will have low performance. Refer to: apache#3646 Matteo has introduced deleteRange API a few years ago, but rollback due to RocksDB delete ranges bug. apache#1620. The RocksDB bug has been addressed since 5.18.0 https://github.com/facebook/rocksdb/blob/main/HISTORY.md#5180-2018-11-30. We can bring the `deleteRange` API back to improve the entry log location deletion performance. ### Changes Bring `deleteRange` API back for entry log location deletion.
Motivation
The entry log location index deletion is deleted in batches one by one currently, and it will have low performance. Refer to: #3646
Matteo has introduced deleteRange API a few years ago, but rollback due to RocksDB delete ranges bug. #1620. The RocksDB bug has been addressed since 5.18.0 https://github.com/facebook/rocksdb/blob/main/HISTORY.md#5180-2018-11-30. We can bring the
deleteRange
API back to improve the entry log location deletion performance.Changes
Bring
deleteRange
API back for entry log location deletion.