Support update ledger metadata option bk-cli #3821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdhabalia
force-pushed
the
led_update
branch
2 times, most recently
from
bc526be
to
6e085a6
Compare
rdhabalia
force-pushed
the
led_update
branch
from
6e085a6
to
461b69f
Compare
Codecov Report
@@ Coverage Diff @@
## master #3821 +/- ##
=============================================
- Coverage 49.79% 32.55% -17.24%
+ Complexity 4817 3107 -1710
=============================================
Files 473 473
Lines 40963 40972 +9
Branches 5240 5241 +1
=============================================
- Hits 20397 13340 -7057
- Misses 18542 25968 +7426
+ Partials 2024 1664 -360
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
merlimat
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Bk-CLI api supports creating ledger metadata from the metadata binary payload-file but it doesn't support updating metadata for existing ledger which will require some time during updating metadata in some operational update usecases. Therefore, support update metadata if ledger already exists by adding a flag.
Changes
bookkeeper shell ledgermetadata -restorefromfilecommand can update ledger-metadata by passing additional--update flag.