Change pendingDeletedLedgers as ConcurrentHashSet #3989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnonHxy
force-pushed
the
improve_queue_remove
branch
from
2a18350
to
1e4fb92
Compare
hangc0276
approved these changes
Jun 19, 2023
|
Good job! |
hangc0276
pushed a commit
to hangc0276/bookkeeper
that referenced
this pull request
Jun 26, 2023
(cherry picked from commit 2baee36)
zymap
pushed a commit
that referenced
this pull request
Aug 29, 2023
(cherry picked from commit 2baee36)
zymap
pushed a commit
that referenced
this pull request
Dec 7, 2023
(cherry picked from commit 2baee36)
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
Motivation
Improve remove performance of
LedgerMetadataIndex#pendingDeletedLedgers.Currently the
pendingDeletedLedgersis aConcurrentLinkedQueue, and we just callremoveandaddandpollmethod of this queue. And it seems that we need not keep the order when poll items from it.Removing items from
ConcurrentLinkedQueueneed traversal the queue. Changing theLedgerMetadataIndex#pendingDeletedLedgersas aConcurrentHashSetwill improve the remove performance.Changes
Changing the
LedgerMetadataIndex#pendingDeletedLedgersas aConcurrentHashSet