-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change pendingDeletedLedgers as ConcurrentHashSet #3989
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2a18350
to
1e4fb92
Compare
HQebupt
approved these changes
Jun 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hangc0276
approved these changes
Jun 19, 2023
Good job! |
StevenLuMT
approved these changes
Jun 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hangc0276
pushed a commit
to hangc0276/bookkeeper
that referenced
this pull request
Jun 26, 2023
(cherry picked from commit 2baee36)
zymap
pushed a commit
that referenced
this pull request
Aug 29, 2023
(cherry picked from commit 2baee36)
zymap
pushed a commit
that referenced
this pull request
Dec 7, 2023
(cherry picked from commit 2baee36)
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
Motivation
Improve remove performance of
LedgerMetadataIndex#pendingDeletedLedgers
.Currently the
pendingDeletedLedgers
is aConcurrentLinkedQueue
, and we just callremove
andadd
andpoll
method of this queue. And it seems that we need not keep the order when poll items from it.Removing items from
ConcurrentLinkedQueue
need traversal the queue. Changing theLedgerMetadataIndex#pendingDeletedLedgers
as aConcurrentHashSet
will improve the remove performance.Changes
Changing the
LedgerMetadataIndex#pendingDeletedLedgers
as aConcurrentHashSet