Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the autorecovery failed replicate by add entry fenced error #4163

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

zymap
Copy link
Member

@zymap zymap commented Dec 24, 2023


Motivation

#3783 changed the recovery add request flags. It causes when replication happening, if the ledger was fenced, the ledger can not be recovered. Because the recovery add flag is not added then the normal add is not allowed to a fenced ledger.

---

### Motivation

apache#3783 changed the recovery add request flags. It causes when
replication happening, if the ledger was fenced, the ledger
can not be recovered. Because the recovery add flag is not
added then the normal add is not allowed to a fenced ledger.
@hangc0276
Copy link
Contributor

@zymap Please fix the check style, thanks.

Copy link
Contributor

@hangc0276 hangc0276 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Catch!

@hangc0276 hangc0276 merged commit eb233b0 into apache:master Jan 8, 2024
16 checks passed
hangc0276 pushed a commit to hangc0276/bookkeeper that referenced this pull request Jan 18, 2024
…he#4163)

* Fix the autorecovery failed replicate by add entry fenced error
---

### Motivation

apache#3783 changed the recovery add request flags. It causes when
replication happening, if the ledger was fenced, the ledger
can not be recovered. Because the recovery add flag is not
added then the normal add is not allowed to a fenced ledger.

(cherry picked from commit eb233b0)
Ghatage pushed a commit to sijie/bookkeeper that referenced this pull request Jul 12, 2024
…he#4163)

* Fix the autorecovery failed replicate by add entry fenced error
---

### Motivation

apache#3783 changed the recovery add request flags. It causes when
replication happening, if the ledger was fenced, the ledger
can not be recovered. Because the recovery add flag is not
added then the normal add is not allowed to a fenced ledger.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants