Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ByteBuf for entrylogger reads #640

Closed
wants to merge 2 commits into from

Conversation

ivankelly
Copy link
Contributor

Original patch from @merlimat in yahoo-4.3 branch

@asfgit
Copy link

asfgit commented Oct 18, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/bookkeeper-precommit-pullrequest-docker/113/

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM great @merlimat

@eolivelli eolivelli added this to the 4.6.0 milestone Oct 18, 2017
@eolivelli eolivelli closed this in 1dc9789 Oct 18, 2017
ivankelly pushed a commit to ivankelly/bookkeeper that referenced this pull request Nov 2, 2017
Original patch from merlimat in yahoo-4.3 branch

Author: Matteo Merli <mmerli@yahoo-inc.com>
Author: Matteo Merli <mmerli@apache.org>

Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Ivan Kelly <ivank@apache.org>

This patch had conflicts when merged, resolved by
Committer: Enrico Olivelli <eolivelli@apache.org>

This closes apache#640 from ivankelly/refcount-for-read
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants