-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 709: Add Slow Bookkeeper Servers to Placement Policy for read ordering #883
Conversation
…e placement policies
This means a separate LICENSE file for server and all, as all pulls in more stuff. Author: Ivan Kelly <ivank@apache.org> Reviewers: Jia Zhai <None>, Sijie Guo <sijie@apache.org> This closes apache#854 from ivankelly/license-fix
…e placement policies
…e placement policies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
} | ||
if (firstRemote != -1) { | ||
int i = 0; | ||
for (;i < remoteNodeInReorderSequence |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can simplify here? for(i=0; i<...; i++)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, lgtm
…psu522/psu/ISSUE-709_fix
Rebase ISSUE 709
thank you @philipsu522 for updating the pull requests. |
waiting for the travis ci to complete the verification. @eolivelli can you take a look at again? I think now the rebase is correct. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 looks good, thank you @philipsu522
Thanks a lot everyone, sorry for all the trouble in rebasing and merging |
retest this please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. great work philip!
ci passed on jdk9, some failures on jdk8 but unrelated to this change. merging it now. |
merged this change to master. @philipsu522 great contribution! well done. |
Descriptions of the changes in this PR:
Maintain a list of slow bookkeeper hosts, which are tried only after readonly bookkeeper hosts are tried. Bookkeeper hosts can be categorized as "slow" when a speculative timeout occurs on that bookkeeper host.
Master Issue:: 709