Issue 709: Add Slow Bookkeeper Servers to Placement Policy for read ordering #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e placement policies
This means a separate LICENSE file for server and all, as all pulls in more stuff. Author: Ivan Kelly <ivank@apache.org> Reviewers: Jia Zhai <None>, Sijie Guo <sijie@apache.org> This closes apache#854 from ivankelly/license-fix
…e placement policies
…e placement policies
yzang
approved these changes
Dec 19, 2017
| } | ||
| if (firstRemote != -1) { | ||
| int i = 0; | ||
| for (;i < remoteNodeInReorderSequence |
There was a problem hiding this comment.
We can simplify here? for(i=0; i<...; i++)
…psu522/psu/ISSUE-709_fix
Rebase ISSUE 709
|
thank you @philipsu522 for updating the pull requests. |
|
waiting for the travis ci to complete the verification. @eolivelli can you take a look at again? I think now the rebase is correct. |
eolivelli
approved these changes
Dec 19, 2017
|
Thanks a lot everyone, sorry for all the trouble in rebasing and merging |
|
retest this please. |
ivankelly
approved these changes
Dec 19, 2017
|
ci passed on jdk9, some failures on jdk8 but unrelated to this change. merging it now. |
|
merged this change to master. @philipsu522 great contribution! well done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
Maintain a list of slow bookkeeper hosts, which are tried only after readonly bookkeeper hosts are tried. Bookkeeper hosts can be categorized as "slow" when a speculative timeout occurs on that bookkeeper host.
Master Issue:: 709