Close config file object (deferred close) #9
Conversation
|
Hi @lyubenblagoev and welcome to our project 😄 The Apache Software Foundation prefers contributors to have submitted a Contributor License Agreement, but for this small change it's not necessary IMO. If you would like to contribute more in the future, please consider submitting an ICLA, as described here. Our Go experts @geomacy @robertgmoss, do you have any comments on this PR? |
| "os" | ||
| "path/filepath" | ||
|
|
||
| "github.com/apache/brooklyn-client/error_handler" |
There was a problem hiding this comment.
Is this change intentional?
There was a problem hiding this comment.
This came from the gofmt tool used by the vim-go plugin. It organizes imports automatically by path and third party packages are separated with blank line from standard library packages.
|
👍 looks good to me, many thanks for the contribution @lyubenblagoev ! |
|
LGTM |
|
Thanks @lyubenblagoev - are you happy to submit a standard Contributor License Agreement, as described by @rdowner above? Can you let us know when you've done that and we'll very happily merge this! |
Config file objects will be closed by the GC, but using the defer statement is always preferable.