-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add docker image generation #118
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - this will be very useful for me and I think it will probably be very useful for other people especially if we start publishing this somewhere so that it can simply be docker pull'ed and run - we could then replace vagrant with this for people using brooklyn for for the first time
Thanks @andreaturli for this, it's great!
Does this require some setup to do first? If yes, I would suggest to add a flag to disable the docker build, same as |
Tested this again and it works like a charm. The plugin (https://github.com/spotify/docker-maven-plugin) come with all the flag necessary to disable the build and push directly the image we just build if if needed. This looks very promising, thanks @andreaturli 👍 |
This is because apache#118 now build docker, therefore the container needs to be able to access the docker engine on the host
This is because apache/brooklyn-dist#118 now build docker, therefore the container needs to be able to access the docker engine on the host
Update docker instructions to mount the docker socket This is because apache/brooklyn-dist#118 now build docker, therefore the container needs to be able to access the docker engine on the host
hi @tbouron what did you do exactly to get round the build error above? I'm getting
This is from a simple |
Upgrading the dockerfile-maven-plugin to 1.4.3 fixed the above for me - have raised #130 |
Hi @geomacy. Indeed, the plugin updated to the latest version when I retested it which worked. Should we bump the version? |
Aaaah just saw your PR @geomacy, never mind then :) |
hey when i was registration my dumbfuccked ass full of subSctances exit me i put my old friking mail in thats not working🤮 please help me guys |
No description provided.