Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docker image generation #118

Merged
merged 2 commits into from Nov 4, 2018

Conversation

Projects
None yet
5 participants
@andreaturli
Copy link
Contributor

andreaturli commented Mar 19, 2018

No description provided.

andreaturli added some commits Mar 17, 2018

@duncangrant
Copy link
Contributor

duncangrant left a comment

LGTM - this will be very useful for me and I think it will probably be very useful for other people especially if we start publishing this somewhere so that it can simply be docker pull'ed and run - we could then replace vagrant with this for people using brooklyn for for the first time

@tbouron

This comment has been minimized.

Copy link
Member

tbouron commented Aug 30, 2018

Thanks @andreaturli for this, it's great!
However, I get an error when I try to build it:

[ERROR] Failed to execute goal com.spotify:dockerfile-maven-plugin:1.4.0:build (default) on project brooklyn-dist: Could not build image: com.spotify.docker.client.shaded.com.fasterxml.jackson.databind.exc.MismatchedInputException: Cannot construct instance of `com.spotify.docker.client.messages.RegistryAuth` (although at least one Creator exists): no String-argument constructor/factory method to deserialize from String value ('swarm')
[ERROR]  at [Source: UNKNOWN; line: -1, column: -1] (through reference chain: java.util.LinkedHashMap["stackOrchestrator"])
[ERROR] -> [Help 1]

Does this require some setup to do first? If yes, I would suggest to add a flag to disable the docker build, same as -D no-deb or -D no-rpm

@tbouron

This comment has been minimized.

Copy link
Member

tbouron commented Nov 4, 2018

Tested this again and it works like a charm. The plugin (https://github.com/spotify/docker-maven-plugin) come with all the flag necessary to disable the build and push directly the image we just build if if needed.

This looks very promising, thanks @andreaturli 👍

@asfgit asfgit merged commit f54d065 into apache:master Nov 4, 2018

1 check passed

Jenkins: brooklyn-dist-pull-request SUCCESS 5 tests run, 1 skipped, 0 failed.
Details

asfgit pushed a commit that referenced this pull request Nov 4, 2018

tbouron added a commit to tbouron/brooklyn-dist that referenced this pull request Nov 4, 2018

Update docker instructions to mount the docker socket
This is because apache#118 now build docker, therefore the container needs to be able to access the docker engine on the host

tbouron added a commit to tbouron/brooklyn that referenced this pull request Nov 4, 2018

Update docker instructions to mount the docker socket
This is because apache/brooklyn-dist#118 now build docker, therefore the container needs to be able to access the docker engine on the host

asfgit pushed a commit that referenced this pull request Nov 12, 2018

Duncan Grant
Closes #129
Update docker instructions to mount the docker socket

This is because #118 now build docker, therefore the container needs to be able to access the docker engine on the host

asfgit pushed a commit to apache/brooklyn that referenced this pull request Nov 12, 2018

Duncan Grant
Closes #24
Update docker instructions to mount the docker socket

This is because apache/brooklyn-dist#118 now build docker, therefore the container needs to be able to access the docker engine on the host
@geomacy

This comment has been minimized.

Copy link
Contributor

geomacy commented Nov 17, 2018

hi @tbouron what did you do exactly to get round the build error above?

I'm getting

[ERROR] Failed to execute goal com.spotify:dockerfile-maven-plugin:1.4.0:build (default) on project brooklyn-dist: Could not build image: com.spotify.docker.client.shaded.com.fasterxml.jackson.databind.exc.MismatchedInputException: Cannot construct instance of `com.spotify.docker.client.messages.RegistryAuth` (although at least one Creator exists): no String-argument constructor/factory method to deserialize from String value ('osxkeychain')
[ERROR]  at [Source: UNKNOWN; line: -1, column: -1] (through reference chain: java.util.LinkedHashMap["credSstore"])

This is from a simple mvn clean install

@geomacy

This comment has been minimized.

Copy link
Contributor

geomacy commented Nov 18, 2018

Upgrading the dockerfile-maven-plugin to 1.4.3 fixed the above for me - have raised #130

@tbouron

This comment has been minimized.

Copy link
Member

tbouron commented Nov 19, 2018

Hi @geomacy. Indeed, the plugin updated to the latest version when I retested it which worked. Should we bump the version?

@tbouron

This comment has been minimized.

Copy link
Member

tbouron commented Nov 19, 2018

Aaaah just saw your PR @geomacy, never mind then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.