BROOKLYN-264: refactor wait-for-provision #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now mark the internal state as provisioning entirely in MachineLifecycleEffectorTasks, and that is also where we wait for it on stop(). This also allows us to test it as a unit test, rather than needing a jclouds live test.
| Transition expectedState = entity().sensors().get(Attributes.SERVICE_STATE_EXPECTED); | ||
|
|
||
| // BROOKLYN-263: see corresponding code in doStop() | ||
| if (expectedState != null && (expectedState.getState() == Lifecycle.STOPPING || expectedState.getState() == Lifecycle.STOPPED)) { |
There was a problem hiding this comment.
Good check, but should it be in this PR?
There was a problem hiding this comment.
I think it's fine to be in this PR. It relates to concurrent calls to start and stop.
| Entities.destroy(app); | ||
| return null; | ||
| } | ||
| }, Asserts.DEFAULT_LONG_TIMEOUT.toMilliseconds(), TimeUnit.MILLISECONDS); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now mark the internal state as provisioning entirely in
MachineLifecycleEffectorTasks, and that is also where we wait for it
on stop(). This also allows us to test it as a unit test, rather than
needing a jclouds live test.
@bostko can you please review?
This builds on #211, which is now merged.