Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Class renames for advanced-networking vcloud-director #522

Merged
merged 2 commits into from
Jan 17, 2017
Merged

Class renames for advanced-networking vcloud-director #522

merged 2 commits into from
Jan 17, 2017

Conversation

aledsage
Copy link
Contributor

@aledsage aledsage mentioned this pull request Jan 17, 2017
Merged
@ivanayov
Copy link
Contributor

Looks good

@aledsage
Copy link
Contributor Author

Thinking about this more, given that brooklyncentral/advanced-networking is not part of Apache Brooklyn, maybe these renames should not be included in core brooklyn. It could be the responsibility of downstream projects to do this (if they are bundling advanced-networking).

Longer term, if we support multiple properties files that are aggregated, then advanced-networking can supply its own renames file.

@asfgit asfgit merged commit 91c602d into apache:master Jan 17, 2017
asfgit pushed a commit that referenced this pull request Jan 17, 2017
@aledsage
This closes #522
fabfcdb
@aledsage aledsage deleted the classRenames-advancedNetworking-vcloudDirector branch January 17, 2017 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@aledsage @ivanayov @asfgit