Avoid package conflicts #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create private-static-class as alternative (but keep anonymous inner class in case it is referenced in persisted state).
This was deprecated in 0.7.0; instead use brooklyn.networking.common.subnet It duplicates a package name in brooklyn-networking-portforwarding, which causes problems in OSGi
Package name was used by two modules (very bad in OSGi) so renaming to brooklyn.networking.vclouddirector.nat in the bundle brooklyn-networking-vcloud-director
|
Looks good |
|
Thanks @iyovcheva - merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for vcloud-director port-forwarding to work in OSGi. The package
brooklyn.networking.vclouddirectorwas previously exported by two different bundles, so those depending on it would only get it from one (and thus would not get access to some classes).On examining the other modules, it was apparent that the same problem exists for
brooklyn.networking.subnet, so fixed that as well.The first commit is a bit unrelated: it avoids the use of anonymous inner classes in persisted state.
I'll create a related PR in brooklyn-server shortly for the package renames (modifying
deserializingClassRenames.properties).