Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix persisting localhost #97

Merged
merged 2 commits into from
Apr 1, 2016
Merged

Conversation

aledsage
Copy link
Contributor

When running org.apache.brooklyn.qa.load.LoadTest, I hit exceptions about serializing localhost machine location. I didn't try rebinding, but I presume the localhost machine's location object would not have been deserialised correctly (or not been available at all).

This PR fixes the two exceptions I hit.

By passing mutexSupport in the machine’s config, it is persisted. But
this tries to pull in persisting threads etc!

It is not necessary to pass it: the Localhost machine overrides the
getMutexSupport().
@ahgittin
Copy link
Contributor

ahgittin commented Apr 1, 2016

yeah the mutexSupport is static so not sure why we go to such great lengths to pass it around; LGTM

@asfgit asfgit merged commit 2dadb24 into apache:master Apr 1, 2016
asfgit pushed a commit that referenced this pull request Apr 1, 2016
@aledsage aledsage deleted the fix/persisting-localhost branch April 4, 2016 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants