fix comments

apache · Jul 24, 2023 · 9de1a1d · 9de1a1d
1 parent 6017f7e
commit 9de1a1d
Showing 1 changed file with 12 additions and 3 deletions.
diff --git a/src/bvar/mvariable.cpp b/src/bvar/mvariable.cpp
@@ -39,19 +39,28 @@ DEFINE_int32(bvar_max_multi_dimension_metric_number, 1024, "Max number of multi
 DEFINE_int32(bvar_max_dump_multi_dimension_metric_number, 1024,
     "Max number of multi dimension metric number to dump by prometheus rpc service");
 
-static bool validator_bvar_max_multi_dimension_metric_number(const char* flag_name, int32_t v) {
+static bool validator_bvar_max_multi_dimension_metric_number(const char*, int32_t v) {
     if (v < 1) {
-        LOG(ERROR) << "Invalid " << flag_name << "=" << v;
+        LOG(ERROR) << "Invalid bvar_max_multi_dimension_metric_number=" << v;
         return false;
     }
     return true;
 }
 
+static bool validator_bvar_max_dump_multi_dimension_metric_number(const char*, int32_t v) {
+    if (v < 0) {
+        LOG(ERROR) << "Invalid bvar_max_dump_multi_dimension_metric_number=" << v;
+        return false;
+    }
+    return true;
+}
+
+
 const bool ALLOW_UNUSED dummp_bvar_max_multi_dimension_metric_number = ::GFLAGS_NS::RegisterFlagValidator(
     &FLAGS_bvar_max_multi_dimension_metric_number, validator_bvar_max_multi_dimension_metric_number);
 
 const bool ALLOW_UNUSED dummp_bvar_max_dump_multi_dimension_metric_number = ::GFLAGS_NS::RegisterFlagValidator(
-  &FLAGS_bvar_max_dump_multi_dimension_metric_number, validator_bvar_max_multi_dimension_metric_number);
+  &FLAGS_bvar_max_dump_multi_dimension_metric_number, validator_bvar_max_dump_multi_dimension_metric_number);
 
 class MVarEntry {
 public: