add bazel third_party support #1996

fansehep · 2022-11-16T03:23:46Z

What problem does this PR solve?

Issue Number: #1992 #1918

Problem Summary: bRPC as thirdparty deps is not easy.

What is changed and the side effects?

Changed: I add a example about 1.3 release how to add bRPC to your project and some about this docs.

I have test in my docker debian9 server. bazel version = 4.2.2
and i have test link @apache_brpc:bthread, bvar, butil, brpc all of them are successful.

Side effects:

Performance effects(性能影响): null
Breaking backward compatibility(向后兼容性): null

Check List:

Please make sure your changes are compilable(请确保你的更改可以通过编译).
When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

wwbmmm · 2022-11-16T03:51:28Z

docs/cn/bazel_support.md

@@ -0,0 +1,14 @@
+## bRPC 作为Bazel第三方依赖
+1. bRPC 依赖于一些开源库, 但这些库并没有提供bazel支持, 所以需要你手动将一部分依赖加入到你的构建项目中.
+2. 将 /example/bazel_1_3_release/build_for_brpc 该文件移动到你的项目根目录下, 将 /example/bazel_1_3_release/build_for_brpc/WORKSPACE_eample 内容添加到你的WORKSPACE中.


eample -> example

eample -> example

🥲 fixed.

wwbmmm · 2022-11-16T03:52:00Z

docs/en/bazel_support.md

@@ -0,0 +1,14 @@
+## bRPC as a Bazel third-party dependency
+1. bRPC relies on a number of open source libraries that do not provide bazel support, so you will need to manually add some of these dependencies to your build project.
+2. Move the file /example/bazel_1_3_release/build_for_brpc to the root of your project, and add the contents of /example/bazel_1_3_release/build_for_brpc/WORKSPACE_eample to your WORKSPACE


eample -> example

eample -> example

fixed.

wwbmmm · 2022-11-16T03:58:00Z

example/bazel_1_3_release/WORKSPACE_example

+)
+
+
+BAZEL_SKYLIB_VERSION = "1.1.1"  # 2021-09-27T17:33:49Z


duplicated with line 23

duplicated with line 23

fixed.

wwbmmm · 2022-11-16T03:58:16Z

example/bazel_1_3_release/WORKSPACE_example

+
+BAZEL_SKYLIB_VERSION = "1.1.1"  # 2021-09-27T17:33:49Z
+
+BAZEL_SKYLIB_SHA256 = "c6966ec828da198c5d9adbaa94c05e3a1c7f21bd012a0b29ba8ddbccb2c93b0d"


duplicated with line 25

duplicated with line 25

fixed.

wwbmmm · 2022-11-16T04:02:01Z

example/bazel_1_3_release/WORKSPACE_example

+
+
+http_archive(
+    name = "bazel_skylib",


duplicated with line 29

Contributor

fixed.

wwbmmm · 2022-11-16T04:03:56Z

example/bazel_1_3_release/test/test.cpp

+#include <bthread/execution_queue.h>
+
+int main () {
+  //


you may call some bthread function here

you may call some bthread function here

should we need a test? the BUILD add a empty test here.

wwbmmm · 2022-11-16T04:07:51Z

docs/cn/bazel_support.md

@@ -0,0 +1,14 @@
+## bRPC 作为Bazel第三方依赖
+1. bRPC 依赖于一些开源库, 但这些库并没有提供bazel支持, 所以需要你手动将一部分依赖加入到你的构建项目中.
+2. 将 /example/bazel_1_3_release/build_for_brpc 该文件移动到你的项目根目录下, 将 /example/bazel_1_3_release/build_for_brpc/WORKSPACE_eample 内容添加到你的WORKSPACE中.


you may change the directory name from bazel_1_3_release to build_with_bazel since there is an existing directory named build_with_old_bazel
And you can follow the directory structure of build_with_old_bazel

wwbmmm · 2022-11-16T04:21:04Z

CI is failed

fansehep · 2022-11-16T04:26:28Z

CI is failed

maybe it is the test failed.

wwbmmm · 2022-11-16T05:53:05Z

docs/cn/bazel_support.md

@@ -0,0 +1,14 @@
+## bRPC 作为Bazel第三方依赖
+1. bRPC 依赖于一些开源库, 但这些库并没有提供bazel支持, 所以需要你手动将一部分依赖加入到你的构建项目中.
+2. 将 /example/build_with_bazel/build_for_brpc 该文件移动到你的项目根目录下, 将 /example/build_with_bazel/build_for_brpc/WORKSPACE_example 内容添加到你的WORKSPACE中.


build_for_brpc/WORKSPACE_example
this path does not exist now

fixed and add a test for it. test is successfull run.

wwbmmm · 2022-11-16T06:13:13Z

docs/cn/bazel_support.md

@@ -0,0 +1,14 @@
+## bRPC 作为Bazel第三方依赖
+1. bRPC 依赖于一些开源库, 但这些库并没有提供bazel支持, 所以需要你手动将一部分依赖加入到你的构建项目中.
+2. 将 /example/build_with_bazel/build_for_brpc 该文件移动到你的项目根目录下, 将 /example/build_with_bazel/build_for_brpc/WORKSPACE 内容添加到你的WORKSPACE中.


remove /build_for_brpc

remove /build_for_brpc

fixed.

wwbmmm · 2022-11-16T10:48:43Z

example/BUILD.bazel

+)
+
+config_setting(
+    name = "have_rdma",


上面有个 //bazel/config:brpc_with_rdma
看能直接复用吗？

wwbmmm · 2022-11-17T02:09:21Z

LGTM

Huixxi · 2022-11-17T02:45:06Z

Does it support MacOS?

fansehep · 2022-11-17T03:12:22Z

Does it support MacOS?

I do not have Mac laptop, you can try it?

Huixxi · 2022-11-17T07:42:55Z

Ok, I will try it later.

guodongxiaren · 2022-11-19T06:39:12Z

Ok, I will try it later.
Mac能生效吗？
@Huixxi

372046933

Could brpc_workspace be applied to BRPC WORKSPACE?

372046933 · 2022-11-20T11:43:56Z

example/build_with_bazel/brpc_workspace.bzl

+    native.new_local_repository(
+        name = "openssl",
+        path = "/usr",
+        build_file = "//:openssl.BUILD",


//:openssl.BUILD actually links to openssl on the system. While openssl in BRPC WORKSPACE is compiled by foreign_rules.
It's better to keep the same with that in BRPC WORKSPACE
So brpc_workspace.bzl is different from the original WORKSPACE file. Could brpc_workspace be used by WORKSPACE in BRPC as well to maintain a consistent WORKSPACE?

fansehep · 2022-11-20T13:35:53Z

Ok, I will try it later.

@Huixxi Have you test successful in MacOS?
Here is a simple demo in this pull request.

cd example/build_with_bazel
bazel build "..."
./bazel-bin/test

Try this?

372046933 · 2022-11-20T14:15:46Z

example/build_with_bazel/brpc_workspace.bzl

-        name = "openssl",
-        path = "/usr",
+    http_archive(
+        name = "openssl",  # 2021-12-14T15:45:01Z


example/build_with_bazel/openssl.BUILD does not build but links to system installed openssl.
Here is the real build:
https://github.com/apache/incubator-brpc/blob/fae30e6a9a84ef8c2e0bfe1ce23afa5611a1ffab/bazel/third_party/openssl/openssl.BUILD#L132

zyearn · 2022-11-30T22:26:44Z

Hi, What's the status on it? Could you update the latest code?

fansehep · 2022-12-01T00:21:46Z

Hi, What's the status on it? Could you update the latest code?

In fact, this is ok. I have tried some other methods, but none of them seem very elegant. So I thinks it can be merged. 😢

89dexua · 2023-12-30T09:40:53Z

Any chance to support protobuf 3.21.9
Tensorflow 2.15.0 not Compatible with protobuf 3.19.1

Simply change the protobuf version got this error message

ERROR: brpc/example/BUILD.bazel:40:14: every rule of type proto_library implicitly depends upon the target '@com_google_protobuf//:protoc', but this target could not be found because of: error loading package '@com_google_protobuf//': cannot load '@com_google_protobuf//:compiler_config_setting.bzl': no such file

fansehep · 2024-01-15T13:30:20Z

Any chance to support protobuf 3.21.9 Tensorflow 2.15.0 not Compatible with protobuf 3.19.1

Simply change the protobuf version got this error message

ERROR: brpc/example/BUILD.bazel:40:14: every rule of type proto_library implicitly depends upon the target '@com_google_protobuf//:protoc', but this target could not be found because of: error loading package '@com_google_protobuf//': cannot load '@com_google_protobuf//:compiler_config_setting.bzl': no such file

Problems with rhombic dependence, Can try change the build stricp brpc protobuf name to fix it.

wwbmmm reviewed Nov 16, 2022

View reviewed changes

add bazel support

538ff1d

fansehep force-pushed the fix_bazel_support branch from cbf2b2a to 538ff1d Compare November 16, 2022 05:35

remove bind

32828ad

fansehep changed the title ~~add bazel third_pary support~~ add bazel third_party support Nov 16, 2022

wwbmmm reviewed Nov 16, 2022

View reviewed changes

update

7e9ccae

wwbmmm reviewed Nov 16, 2022

View reviewed changes

fansehep added 3 commits November 16, 2022 06:16

update

ca21deb

update

34b8165

update doc

ed1884a

wwbmmm reviewed Nov 16, 2022

View reviewed changes

fansehep added 2 commits November 16, 2022 11:49

fix rdma bazel build

616cfc6

update

d353752

372046933 reviewed Nov 20, 2022

View reviewed changes

fansehep force-pushed the fix_bazel_support branch from 3109a27 to d353752 Compare November 23, 2022 07:08

wwbmmm merged commit 0aa1cf1 into apache:master Dec 6, 2022

Superskyyy mentioned this pull request Feb 1, 2024

Unify bRPC third party support doc/example with the bazel WORKSPACE file #2531

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add bazel third_party support #1996

add bazel third_party support #1996

fansehep commented Nov 16, 2022 •

edited

Loading

wwbmmm Nov 16, 2022

fansehep Nov 16, 2022

wwbmmm Nov 16, 2022

fansehep Nov 16, 2022

wwbmmm Nov 16, 2022

fansehep Nov 16, 2022

wwbmmm Nov 16, 2022

fansehep Nov 16, 2022

wwbmmm Nov 16, 2022

fansehep Nov 16, 2022

wwbmmm Nov 16, 2022

fansehep Nov 16, 2022

wwbmmm Nov 16, 2022

fansehep Nov 16, 2022

wwbmmm commented Nov 16, 2022

fansehep commented Nov 16, 2022

wwbmmm Nov 16, 2022 •

edited

Loading

fansehep Nov 16, 2022 •

edited

Loading

wwbmmm Nov 16, 2022

fansehep Nov 16, 2022

wwbmmm Nov 16, 2022

wwbmmm commented Nov 17, 2022

Huixxi commented Nov 17, 2022

fansehep commented Nov 17, 2022

Huixxi commented Nov 17, 2022

guodongxiaren commented Nov 19, 2022

372046933 left a comment

372046933 Nov 20, 2022

fansehep commented Nov 20, 2022

372046933 Nov 20, 2022

zyearn commented Nov 30, 2022

fansehep commented Dec 1, 2022

89dexua commented Dec 30, 2023 •

edited

Loading

fansehep commented Jan 15, 2024


		BAZEL_SKYLIB_VERSION = "1.1.1" # 2021-09-27T17:33:49Z

		BAZEL_SKYLIB_SHA256 = "c6966ec828da198c5d9adbaa94c05e3a1c7f21bd012a0b29ba8ddbccb2c93b0d"

add bazel third_party support #1996

add bazel third_party support #1996

Conversation

fansehep commented Nov 16, 2022 • edited Loading

What problem does this PR solve?

What is changed and the side effects?

Check List:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wwbmmm commented Nov 16, 2022

fansehep commented Nov 16, 2022

wwbmmm Nov 16, 2022 • edited Loading

Choose a reason for hiding this comment

fansehep Nov 16, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wwbmmm commented Nov 17, 2022

Huixxi commented Nov 17, 2022

fansehep commented Nov 17, 2022

Huixxi commented Nov 17, 2022

guodongxiaren commented Nov 19, 2022

372046933 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fansehep commented Nov 20, 2022

Choose a reason for hiding this comment

zyearn commented Nov 30, 2022

fansehep commented Dec 1, 2022

89dexua commented Dec 30, 2023 • edited Loading

fansehep commented Jan 15, 2024

fansehep commented Nov 16, 2022 •

edited

Loading

wwbmmm Nov 16, 2022 •

edited

Loading

fansehep Nov 16, 2022 •

edited

Loading

89dexua commented Dec 30, 2023 •

edited

Loading