Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make bvar_max_dump_multi_dimension_metric_number modifiable #2322

Merged
merged 2 commits into from
Jul 26, 2023
Merged

make bvar_max_dump_multi_dimension_metric_number modifiable #2322

merged 2 commits into from
Jul 26, 2023

Conversation

lhsoft
Copy link
Contributor

@lhsoft lhsoft commented Jul 20, 2023

What problem does this PR solve?

Issue Number:

Problem Summary:

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):

Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

serverglen
serverglen reviewed Jul 20, 2023
View reviewed changes
src/bvar/mvariable.cpp Outdated Show resolved Hide resolved
@serverglen
Copy link
Contributor

LGTM

@wwbmmm wwbmmm merged commit 3bc4366 into apache:master Jul 26, 2023
16 checks passed
yanglimingcn pushed a commit to yanglimingcn/brpc that referenced this pull request Oct 31, 2023
@lhsoft
make bvar_max_dump_multi_dimension_metric_number modifiable (apache#2322
db5c2d8 
)

* make bvar_max_dump_multi_dimension_metric_number modifiable

* fix comments

---------

Co-authored-by: lhsoft <liuhuwork@gmail.com>
yanglimingcn pushed a commit to yanglimingcn/brpc that referenced this pull request Oct 31, 2023
@lhsoft
make bvar_max_dump_multi_dimension_metric_number modifiable (apache#2322
c2e8a8e 
)

* make bvar_max_dump_multi_dimension_metric_number modifiable

* fix comments

---------

Co-authored-by: lhsoft <liuhuwork@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serverglen serverglen serverglen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lhsoft @serverglen @wwbmmm