[CALCITE-4575] Remove Gradle wrapper from source distribution #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @julianhyde I'll test, confirm and merge this during the release. |
|
I have added a commit with a fix for https://issues.apache.org/jira/browse/CALCITE-4576. Please review that also. |
|
Was the fix for CALCITE-4576 a separate commit? I think you forgot to push it, so you will need to open a new PR for it. |
|
I've pushed it to the same branch. No PR needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review, but do not merge.
@F21, I think you should merge this (with corrections, if necessary) during your process, as release manager, to create 1.18.0 RC1.