[CALCITE-2855] Make RelOptCluster constructor public #1055
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds like a bad idea. Not least because the method you made public was deprecated. |
godfreyhe
force-pushed
the
CALCITE-2855
branch
from
23b0b8d
to
7757f95
Compare
|
I had reverted some changes, only make non-deprecated constructor as public |
|
Well, it's a bad idea for some other reasons that someone else raised. |
|
Hi @julianhyde, do you have any suggestion about the topic in: https://issues.apache.org/jira/browse/CALCITE-2855. Looking forward your advice, thanks very much! |
|
Going to close this PR since it looks like the conversation on JIRA went in a different direction. It can be reopened if this is the right direction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose RelOptCluster Constructor outside package to allow override.