Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CALCITE-3146] Support the detection of nested aggregations for JdbcAggregate in SqlImplementor #1278

Merged
merged 1 commit into from
Jul 1, 2019
Merged

[CALCITE-3146] Support the detection of nested aggregations for JdbcAggregate in SqlImplementor #1278

merged 1 commit into from
Jul 1, 2019

Conversation

wenhuitang
Copy link
Contributor

@vlsi vlsi added returned-with-feedback There are review comments (in JIRA and/or in GitHub) to be implemented before merging the PR tests-missing labels Jun 25, 2019
chunweilei
chunweilei reviewed Jun 26, 2019
View reviewed changes
Copy link
Contributor

@chunweilei chunweilei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

danny0405
danny0405 approved these changes Jun 26, 2019
View reviewed changes
Copy link
Contributor

@danny0405 danny0405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the exists tests should already cover the code, so missing test is ok for me.

@vlsi
Copy link
Contributor

vlsi commented Jun 26, 2019

I think the exists tests should already cover the code, so missing test is ok for me.

Nothing prevents from re-introducing the bug.

@julianhyde
Copy link
Contributor

Not nothing. Human diligence prevents it.

Even if there is a regression test someone could remove it. But we assume good faith, so we assume that doesn't happen.

@hsyuan hsyuan merged commit eb47b37 into apache:master Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunweilei chunweilei chunweilei left review comments

@danny0405 danny0405 danny0405 approved these changes

Assignees
No one assigned
Labels
returned-with-feedback There are review comments (in JIRA and/or in GitHub) to be implemented before merging the PR tests-missing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wenhuitang @vlsi @julianhyde @danny0405 @chunweilei @hsyuan