Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CALCITE-3262] Refine doc of SubstitutionVisitor.java #1388

Merged
merged 1 commit into from
Aug 21, 2019

Conversation

jinxing64
Copy link
Contributor

Current doc of SubstitutionVisitor.java says the supported core relational operators are @link org.apache.calcite.rel.logical.LogicalTableScan, and so on.
But with convertTableAccess=true (https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java#L5636), it's a EnumerableTableScan under MutableScan, which is inconsistent with the doc.
And what's more, MutableRels and SubstitutionVisitor supporting scope doesn't limit to be org.apache.calcite.rel.logical.LogicalXXX.
So I think it might make sense to update/refine the doc to say that the supported core relational operators are

 * {@link org.apache.calcite.rel.core.TableScan},
 * {@link org.apache.calcite.rel.core.Filter},
 * {@link org.apache.calcite.rel.core.Project},
 * {@link org.apache.calcite.rel.core.Join},
 * {@link org.apache.calcite.rel.core.Union},
 * {@link org.apache.calcite.rel.core.Aggregate}.</p>

Copy link
Member

@hsyuan hsyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@hsyuan hsyuan added the LGTM-will-merge-soon Overall PR looks OK. Only minor things left. label Aug 20, 2019
@jinxing64
Copy link
Contributor Author

@hsyuan
Thanks a lot for approve !

@hsyuan hsyuan merged commit 9fd9c82 into apache:master Aug 21, 2019
@jinxing64
Copy link
Contributor Author

Thanks for merging ~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM-will-merge-soon Overall PR looks OK. Only minor things left.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants