[CALCITE-3262] Refine doc of SubstitutionVisitor.java #1388
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current doc of
SubstitutionVisitor.java
says the supported core relational operators are@link org.apache.calcite.rel.logical.LogicalTableScan
, and so on.But with
convertTableAccess=true
(https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java#L5636), it's aEnumerableTableScan
underMutableScan
, which is inconsistent with the doc.And what's more,
MutableRels
andSubstitutionVisitor
supporting scope doesn't limit to beorg.apache.calcite.rel.logical.LogicalXXX
.So I think it might make sense to update/refine the doc to say that the supported core relational operators are