[CALCITE-3694] Implement SINH function #1725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanlin-Lynn
reviewed
Jan 7, 2020
| @@ -1705,6 +1705,7 @@ public SqlOperandCountRange getOperandCountRange() { | |||
| OperandTypes.NUMERIC, | |||
| SqlFunctionCategory.NUMERIC); | |||
|
|
|||
| public static final SqlFunction SINH = SqlLibraryOperators.SINH; | |||
There was a problem hiding this comment.
is SINH part of standard SQL ?
There was a problem hiding this comment.
is
SINHpart of standard SQL ?
Actually I want to support standard SQL at the same time.
There was a problem hiding this comment.
Well, I think if it's not part of standard SQL, it should not be in SqlStdOperatorTable
There was a problem hiding this comment.
Well, I think if it's not part of standard SQL, it should not be in
SqlStdOperatorTable
hi @yanlin-Lynn I have changed it.
XuQianJin-Stars
force-pushed
the
CALCITE-3694
branch
from
09f7011
to
b3bd01f
Compare
| @@ -2325,6 +2325,7 @@ semantics. | |||
| | o | RTRIM(string) | Returns *string* with all blanks removed from the end | |||
| | m p | SHA1(string) | Calculates a SHA-1 hash value of *string* and returns it as a hex string | |||
| | m o p | SOUNDEX(string) | Returns the phonetic representation of *string*; throws if *string* is encoded with multi-byte encoding such as UTF-8 | |||
| | o | SINH(numeric) | Returns the hyperbolic sine of *numeric* | |||
There was a problem hiding this comment.
Lets maintain alphabetical order :)
chunweilei
added
the
LGTM-will-merge-soon
XuQianJin-Stars
force-pushed
the
CALCITE-3694
branch
from
b21081f
to
d8ae8ba
Compare
XuQianJin-Stars
force-pushed
the
CALCITE-3694
branch
from
d8ae8ba
to
e77c584
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As illustrated in CALCITE-3694
SINH function returns the hyperbolic sine of a number.
select sinh(1);
+--------------------+
| EXPR$0 |
+--------------------+
| 1.1752011936438014 |
+--------------------+
(1 row)
!ok