[CALCITE-4208] Improve metadata row count for Join #2131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaliujia
reviewed
Sep 2, 2020
amaliujia
reviewed
Sep 2, 2020
core/src/test/java/org/apache/calcite/test/RelMetadataTest.java
Outdated
Show resolved
Hide resolved
vlsi
reviewed
Sep 3, 2020
core/src/main/java/org/apache/calcite/rel/metadata/RelMdUtil.java
Outdated
Show resolved
Hide resolved
rubenada
force-pushed
the
CALCITE-4208
branch
from
77bd083
to
529c143
Compare
rubenada
added
the
LGTM-will-merge-soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the default metadata row count for join
RelMdRowCount#getRowCount(Join rel, RelMetadataQuery mq)relies onRelMdUtil.getJoinRowCount. This method has several issues:leftRowCount * rightRowCount * mq.getSelectivity(join, condition)which seems valid for an INNER join, but not for LEFT / RIGHT / FULL.
The goal of this patch is fixing the ANTI computation and providing a more accurate value for LEFT / RIGHT / FULL.