[CALCITE-4402] The equalsDeep returns wrong result #2264
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method equalsDeep of SqlCall will returns wrong result when used to compare count and count_distinct, because it does not compare the functionQuantifier
danny0405
reviewed
Nov 16, 2020
| @@ -146,6 +146,9 @@ public int operandCount() { | |||
| return litmus.fail("{} != {}", this, node); | |||
| } | |||
| SqlCall that = (SqlCall) node; | |||
| if (!equalDeep(this.getFunctionQuantifier(), that.getFunctionQuantifier(), litmus)) { | |||
| return litmus.fail("{} != {}", this, node); | |||
| } | |||
There was a problem hiding this comment.
Thanks for the fix, can you also add test case there.
|
Can you also log an issue here: https://issues.apache.org/jira/projects/CALCITE/issues/CALCITE-4263?filter=allopenissues, Your commit message should be with format: [CALCITE-{issue number}] {Your title} ({your GitHub account}). |
|
Thank you for your fix. You can find more about how to contribute in https://calcite.apache.org/develop/#contributing. |
hqx871
changed the title
hqx871
changed the title
Thanks. |
danny0405
reviewed
Nov 17, 2020
| @@ -30,6 +30,10 @@ The [Apache Calcite PMC]({{ site.baseurl }}) | |||
| is pleased to announce | |||
| [Apache Calcite release 1.26.0]({{ site.baseurl }}/docs/history.html#v1-26-0). | |||
|
|
|||
| **Warning:** Calcite 1.26.0 has **severe** issues with `RexNode` simplification caused by `SEARCH operator` ( | |||
| wrong data from query optimization, `NullPointerException`), so use 1.26.0 for development only, | |||
| and beware that Calcite 1.26.0 would corrupt your data. | |||
There was a problem hiding this comment.
This may be from another contributor
Following [CALCITE-4364], fix the plan diff of TpcdsTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method equalsDeep of SqlCall will returns wrong result when used to compare count and count_distinct, because it does not compare the functionQuantifier