Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CALCITE-5157] Fix ClassCastException in checkRollUp with DOT operator #2808

Closed
wants to merge 3 commits into from
Closed

[CALCITE-5157] Fix ClassCastException in checkRollUp with DOT operator #2808

wants to merge 3 commits into from

Conversation

viliam-durina
Copy link
Contributor

@viliam-durina viliam-durina commented May 17, 2022 •
edited
Loading

chunweilei
chunweilei reviewed May 19, 2022
View reviewed changes
core/src/test/java/org/apache/calcite/test/ReflectiveSchemaTest.java
.with(CalciteAssert.SchemaSpec.BOOKSTORE)
.query("select (\"birthPlace\").\"city\" as city from \"bookstore\".\"authors\"\n")
.returnsUnordered("CITY=Heraklion", "CITY=Besançon", "CITY=Ionia");
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR, @viliam-durina. I left some comments in JIRA.

@chunweilei chunweilei added the discussion-in-jira There's open discussion in JIRA to be resolved before proceeding with the PR label May 19, 2022
julianhyde pushed a commit to julianhyde/calcite that referenced this pull request Jun 20, 2022
@viliam-durina @julianhyde
[CALCITE-5157] Query that applies dot operator (field access) to pare…
e5b668d 
…nthesized expression throws ClassCastException

For example,
  SELECT (item).name
  FROM on_hand
throws ClassCastException in checkRollUp while
  SELECT item.name
  FROM on_hand
succeeds.

Close apache#2808
julianhyde pushed a commit to julianhyde/calcite that referenced this pull request Jun 20, 2022
@viliam-durina @julianhyde
[CALCITE-5157] Query that applies dot operator (field access) to pare…
bac8acb 
…nthesized expression throws ClassCastException

For example,
  SELECT (item).name
  FROM on_hand
throws ClassCastException in checkRollUp while
  SELECT item.name
  FROM on_hand
succeeds.

Close apache#2808
julianhyde pushed a commit to julianhyde/calcite that referenced this pull request Jun 21, 2022
@viliam-durina @julianhyde
[CALCITE-5157] Query that applies dot operator (field access) to pare…
f408116 
…nthesized expression throws ClassCastException

For example,
  SELECT (item).name
  FROM on_hand
throws ClassCastException in checkRollUp while
  SELECT item.name
  FROM on_hand
succeeds.

Close apache#2808
aymeric-dispa pushed a commit to aymeric-dispa/calcite that referenced this pull request Jul 23, 2022
@viliam-durina @aymeric-dispa
[CALCITE-5157] Query that applies dot operator (field access) to pare…
c0a7633 
…nthesized expression throws ClassCastException

For example,
  SELECT (item).name
  FROM on_hand
throws ClassCastException in checkRollUp while
  SELECT item.name
  FROM on_hand
succeeds.

Close apache#2808
tanclary pushed a commit to tanclary/calcite that referenced this pull request Nov 11, 2022
@viliam-durina @tanclary
[CALCITE-5157] Query that applies dot operator (field access) to pare…
f1ce0fb 
…nthesized expression throws ClassCastException

For example,
  SELECT (item).name
  FROM on_hand
throws ClassCastException in checkRollUp while
  SELECT item.name
  FROM on_hand
succeeds.

Close apache#2808
tanclary pushed a commit to tanclary/calcite that referenced this pull request Nov 28, 2022
@viliam-durina @tanclary
[CALCITE-5157] Query that applies dot operator (field access) to pare…
447037f 
…nthesized expression throws ClassCastException

For example,
  SELECT (item).name
  FROM on_hand
throws ClassCastException in checkRollUp while
  SELECT item.name
  FROM on_hand
succeeds.

Close apache#2808
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunweilei chunweilei chunweilei left review comments

Assignees
No one assigned
Labels
discussion-in-jira There's open discussion in JIRA to be resolved before proceeding with the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@viliam-durina @chunweilei