[CALCITE-5259] Add getParameterRowType method to Planner interface #2890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dssysolyatin
force-pushed
the
CALCITE-5259
branch
2 times, most recently
from
0aea0cd
to
531b017
Compare
dssysolyatin
force-pushed
the
CALCITE-5259
branch
from
531b017
to
f4cd814
Compare
jbalint
requested changes
Nov 29, 2022
Comment on lines
+241
to
+243
| if (state.ordinal() < State.STATE_4_VALIDATED.ordinal()) { | ||
| throw new RuntimeException("Need to call #validate() first"); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (state.ordinal() < State.STATE_4_VALIDATED.ordinal()) { | |
| throw new RuntimeException("Need to call #validate() first"); | |
| } | |
| ensure(State.STATE_4_VALIDATED);``` |
There was a problem hiding this comment.
@jbalint
ensure works differently. ensure checks if planner can move to next state. if ensure is used and user calls getParameterRowType from STATE_5_CONVERTED state, the getParameterRowType will throw exception
There was a problem hiding this comment.
yes - you're right. the javadoc is wrong... :(
jbalint
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.