[CALCITE-6312] Add LOG function (enabled in PostgreSQL library) #3839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In order to prevent LogImplementor from making the code redundant, I added SqlLibrary for identification. @normanj-bitquill If the log function in Redshift is the same as postgres please let me know so I can modify it |
YiwenWu
reviewed
Jul 2, 2024
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java
Outdated
Show resolved
Hide resolved
YiwenWu
suggested changes
Jul 3, 2024
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java
Outdated
Show resolved
Hide resolved
| final SqlOperatorFixture f = f0.withLibrary(SqlLibrary.POSTGRESQL); | ||
| f.checkScalar("log(10, 10)", 1.0, | ||
| "DOUBLE NOT NULL"); | ||
| f.checkScalar("log(64, 8)", 2.0, |
There was a problem hiding this comment.
LOG(base, value), the result of log(64, 8) is not 2.0
There was a problem hiding this comment.
ohhh, seems to be a bug in sqlfunctions, I open a new jira case, bigquery is log(64, 8) == 2?
I overlooked the problem, and I'm sorry
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java
Outdated
Show resolved
Hide resolved
caicancai
force-pushed
the
6312
branch
2 times, most recently
from
fa068f0
to
97d0d99
Compare
YiwenWu
suggested changes
Jul 5, 2024
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java
Outdated
Show resolved
Hide resolved
|
@YiwenWu @XuQianJin-Stars @NobiGo PATL, thanks |
YiwenWu
reviewed
Jul 8, 2024
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java
Outdated
Show resolved
Hide resolved
YiwenWu
reviewed
Jul 8, 2024
mihaibudiu
requested changes
Jul 13, 2024
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java
Outdated
Show resolved
Hide resolved
mihaibudiu
requested changes
Jul 15, 2024
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java
Outdated
Show resolved
Hide resolved
mihaibudiu
reviewed
Jul 16, 2024
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java
Outdated
Show resolved
Hide resolved
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java
Outdated
Show resolved
Hide resolved
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java
Outdated
Show resolved
Hide resolved
caicancai
force-pushed
the
6312
branch
2 times, most recently
from
69e9e93
to
e44286e
Compare
mihaibudiu
reviewed
Jul 18, 2024
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java
Outdated
Show resolved
Hide resolved
mihaibudiu
approved these changes
Jul 18, 2024
mihaibudiu
added
the
LGTM-will-merge-soon
|
|
@mihaibudiu @YiwenWu @XuQianJin-Stars Thank you for your review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/CALCITE-6312
https://issues.apache.org/jira/browse/CALCITE-6456